Repository navigation
fix(server): skip disabled provider instances for text generation fallback - #249
Merged
Merged
Conversation
…lback Disabling Codex in Settings still sent titles, branch names, and commit copy to Codex because fallback only read the legacy providers map, which decodes to schema defaults with Codex enabled. The fallback now checks the providerInstances entry first, matching isModelSelectionProviderEnabled, and only uses the legacy map when there is no instance. Upstream: pingdotgg#10346 Grok 4.6 High in Grok Build via Orca.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
Bot
added
vouch:trusted
Greptile SummarySummary
Confidence Score: 5/5Safe to merge. There are no outstanding findings. Reviews (2): Last reviewed commit: "Merge branch 'main' into fix/text-genera..." | Re-trigger Greptile |
This was referenced Sep 11, 2026
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
fallbackTextGenerationProvider read only the legacy settings.providers map when the configured text generation selection was disabled. The Providers UI writes providerInstances only, so that map decodes to schema defaults where Codex is enabled and listed first. Disabling Codex in Settings still sent every title, branch name, commit message, and PR request to Codex.
Fix
The fallback now checks the providerInstances entry for each driver first, with the same precedence isModelSelectionProviderEnabled already uses, and only reads the legacy providers map when there is no instance entry.
This is an Akeru adaptation of upstream T3 Code work. All five providers keep the same fallback order.
Upstream
Verification
vp test run apps/server/src/serverSettings.test.ts— 41 passedModel
Grok 4.6 High in Grok Build via Orca.