Skip to content

Add mount label man page content#53

Merged
mrunalp merged 1 commit into
opencontainers:masterfrom
rhatdan:selinux
May 2, 2016
Merged

Add mount label man page content#53
mrunalp merged 1 commit into
opencontainers:masterfrom
rhatdan:selinux

Conversation

@rhatdan

@rhatdan rhatdan commented May 2, 2016

Copy link
Copy Markdown
Contributor

Signed-off-by: Dan Walsh dwalsh@redhat.com

@rhatdan rhatdan changed the title Add mount label support Add mount label man page content May 2, 2016
@mrunalp

mrunalp commented May 2, 2016

Copy link
Copy Markdown
Contributor

We don't need to pull in the Godeps/_workspace/src/github.com/opencontainers/runtime-spec/specs-go/config.go change as the MountLabel change is already included under struct Linux.

@rhatdan

rhatdan commented May 2, 2016

Copy link
Copy Markdown
Contributor Author

Fixed

@mrunalp

mrunalp commented May 2, 2016

Copy link
Copy Markdown
Contributor

Could you move this above --network? We recently sorted the options in alphabetic order. Thanks!

Signed-off-by: Dan Walsh <dwalsh@redhat.com>
@mrunalp

mrunalp commented May 2, 2016

Copy link
Copy Markdown
Contributor

LGTM

@mrunalp
mrunalp merged commit 8ab86b6 into opencontainers:master May 2, 2016
You can use SELinux to add security to the container. You must specify the process label to run the init process inside of the container using the --selinux-label.

# ocitools generate --bind /var/db:/data1 --selinux-label system_u:system_r:svirt_lxc_net_t:s0:c1,c2 --rootfs /var/lib/containers/fedora --args bash
# ocitools generate --bind /var/db:/data1 --selinux-label system_u:system_r:svirt_lxc_net_t:s0:c1,c2 --mount-label system_u:object_r:svirt_sandbox_file_t:s0:c1,c2 --rootfs /var/lib/containers/fedora --args bash

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Busted rebase partially rolling back #46?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What did I break?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdown literals need four-space indents (or fencing).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I was looking for something in the text I changed. I fixed the markdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants