Skip to content

Bump v1.0rc1#486

Merged
mrunalp merged 3 commits into
opencontainers:masterfrom
vbatts:bump-v1.0rc1
Jun 3, 2016
Merged

Bump v1.0rc1#486
mrunalp merged 3 commits into
opencontainers:masterfrom
vbatts:bump-v1.0rc1

Conversation

@vbatts

@vbatts vbatts commented Jun 3, 2016

Copy link
Copy Markdown
Member

where ef1aa37 would be tagged v1.0.0-rc1

@wking

wking commented Jun 3, 2016

Copy link
Copy Markdown
Contributor

On Fri, Jun 03, 2016 at 12:17:15PM -0700, Vincent Batts wrote:

  • version: v1.0.0-rc1

The series through 41bfb58 looks fine to me, although I went with
“rc.1” in the ChangeLog to match SemVer's own versioning 1. §9
talks about “dot separated identifiers” in the pre-release version.
But it probably only matters for sorting (e.g. rc10 probably sorts
before rc9, but rc.10 probably sorts after rc.9).

@vbatts

vbatts commented Jun 3, 2016

Copy link
Copy Markdown
Member Author

@wking the link is a 404.

I'm not really sure that I've run into -rc.N much if ever. While I don't entirely care, it is very common to see -rcN

@wking

wking commented Jun 3, 2016

Copy link
Copy Markdown
Contributor

On Fri, Jun 03, 2016 at 12:29:29PM -0700, Vincent Batts wrote:

@wking the link is a 404.

Sorry, should have been: http://semver.org/spec/v2.0.0.html

I'm not really sure that I've run into -rc.N much if ever. While I
don't entirely care, it is very common to see -rcN

We're unlikely to hit rc.10 ;). I think we should follow the SemVer
example, but yeah, it doesn't matter much. Whichever way we go, the
ChangeLog, subsequent Go, and tag should be consistent.

wking and others added 3 commits June 3, 2016 15:47
Through 303c03a (Merge pull request opencontainers#412 from
wking/explicit-uid-namespace, 2016-06-03).

Signed-off-by: W. Trevor King <wking@tremily.us>
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
@crosbymichael

Copy link
Copy Markdown
Member

rc1 over rc.1 is much better

@crosbymichael

crosbymichael commented Jun 3, 2016

Copy link
Copy Markdown
Member

LGTM

Approved with PullApprove

@wking

wking commented Jun 3, 2016

Copy link
Copy Markdown
Contributor

On Fri, Jun 03, 2016 at 12:58:28PM -0700, Michael Crosby wrote:

rc1 over rc.1 is much better

I don't see much difference, and certainly nothing superior about
the short form, but feel free to reroll my ChangeLog commit to adjust
‘rc.1’ → ‘rc1’.

@crosbymichael

Copy link
Copy Markdown
Member

It already is adjusted

@tianon

tianon commented Jun 3, 2016

Copy link
Copy Markdown
Member

LGTM

IIRC, rc.N is primarily a python thing, but IMO rcN looks better and is much more common

Approved with PullApprove

@mrunalp

mrunalp commented Jun 3, 2016

Copy link
Copy Markdown
Contributor

LGTM

Approved with PullApprove

@mrunalp
mrunalp merged commit b953df4 into opencontainers:master Jun 3, 2016
@crosbymichael

Copy link
Copy Markdown
Member

@vbatts let me know if you get a chance to push the tag or i can do it

@crosbymichael

Copy link
Copy Markdown
Member

0647920 should be the new commit to tag correct?

@wking

wking commented Jun 3, 2016

Copy link
Copy Markdown
Contributor

On Fri, Jun 03, 2016 at 03:03:17PM -0700, Michael Crosby wrote:

0647920 should be the new commit to tag correct?

Yup.

@crosbymichael

crosbymichael commented Jun 3, 2016

Copy link
Copy Markdown
Member

@wking

wking commented Jun 3, 2016

Copy link
Copy Markdown
Contributor

On Fri, Jun 03, 2016 at 03:23:14PM -0700, Michael Crosby wrote:

ok, pushed the tag

Not signed?

@vbatts
vbatts deleted the bump-v1.0rc1 branch June 6, 2016 14:58
@wking wking mentioned this pull request Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants