Skip to content

Fix Namespaces to use LinuxNamespaceType#1007

Merged
crosbymichael merged 1 commit into
opencontainers:masterfrom
KentaTada:Fix-Namespaces-to-use-LinuxNamespaceType
May 7, 2019
Merged

Fix Namespaces to use LinuxNamespaceType#1007
crosbymichael merged 1 commit into
opencontainers:masterfrom
KentaTada:Fix-Namespaces-to-use-LinuxNamespaceType

Conversation

@KentaTada

@KentaTada KentaTada commented Apr 19, 2019

Copy link
Copy Markdown
Contributor

LinuxNamespaceType is defined but it is only used for PIDNamespace.
I think all Namespaces should use this type.

Signed-off-by: Kenta Tada Kenta.Tada@sony.com

Signed-off-by: Kenta Tada <Kenta.Tada@sony.com>
@KentaTada

Copy link
Copy Markdown
Contributor Author

Could you review this commit? cc @vbatts @crosbymichael @cyphar @alban
BTW, I don't know why checks were failed although "Signed-off-by" was added.

@tianon

tianon commented May 7, 2019

Copy link
Copy Markdown
Member

LGTM

Approved with PullApprove

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (not a maintainer)

@crosbymichael

crosbymichael commented May 7, 2019

Copy link
Copy Markdown
Member

LGTM

Approved with PullApprove

@crosbymichael
crosbymichael merged commit 5b71a03 into opencontainers:master May 7, 2019
@vbatts vbatts mentioned this pull request Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants