Skip to content

Adding oom_score_adj as a container config param#232

Merged
mrunalp merged 1 commit into
opencontainers:masterfrom
vishh:oom-score-adj
Aug 31, 2015
Merged

Adding oom_score_adj as a container config param#232
mrunalp merged 1 commit into
opencontainers:masterfrom
vishh:oom-score-adj

Conversation

@vishh

@vishh vishh commented Aug 28, 2015

Copy link
Copy Markdown
Contributor

No description provided.

@vishh

vishh commented Aug 28, 2015

Copy link
Copy Markdown
Contributor Author

cc @mrunalp

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think could point to https://www.kernel.org/doc/Documentation/filesystems/proc.txt instead as oom_score_adj can't be found on the lwn page.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion. Updated!

@mrunalp

mrunalp commented Aug 28, 2015

Copy link
Copy Markdown
Contributor

Also, you might want to propose this to the spec to expose it in the config :)

@vishh

vishh commented Aug 29, 2015

Copy link
Copy Markdown
Contributor Author

Yes. The next PR will be add this to the Spec.

Comment thread libcontainer/integration/exec_test.go Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment needs to be updated.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Good catch :)

@wking

wking commented Aug 29, 2015

Copy link
Copy Markdown
Contributor

On Fri, Aug 28, 2015 at 05:32:38PM -0700, Vish Kannan wrote:

Yes. The next PR will be add this to the Spec.

Is a spec entry how we want to handle this? See
opencontainers/runtime-spec#115, where I suggest using a pre-start hook if
possible. I just haven't gotten around to testing if #160 will make
it possible or not (although see also my uncertainty about the hook
environment 1).

Signed-off-by: Vishnu Kannan <vishnuk@google.com>
@vishh

vishh commented Aug 31, 2015

Copy link
Copy Markdown
Contributor Author

Ping @crosbymichael @LK4D4

@LK4D4

LK4D4 commented Aug 31, 2015

Copy link
Copy Markdown
Contributor

LGMT

@mrunalp

mrunalp commented Aug 31, 2015

Copy link
Copy Markdown
Contributor

LGTM

mrunalp pushed a commit that referenced this pull request Aug 31, 2015
Adding oom_score_adj as a container config param
@mrunalp
mrunalp merged commit 5c92e5d into opencontainers:master Aug 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants