Skip to content

Add Brandon as maintainer - #909

Merged
vbatts merged 4 commits into
opencontainers:mainfrom
jdolitsky:brandon
Aug 10, 2022
Merged

Add Brandon as maintainer#909
vbatts merged 4 commits into
opencontainers:mainfrom
jdolitsky:brandon

Conversation

@jdolitsky

@jdolitsky jdolitsky commented Apr 29, 2022

Copy link
Copy Markdown
Contributor

Nomination for a New Maintainer

Nominating Maintainer

jdolitsky

New Maintainer

sudo-bmitch

Justification

  • Attendance in OCI weekly meetings
  • Activity in image-spec/distribution-spec issues relating to extending specs
  • Contributing to the OCI Reference Types working group
  • Overall solid person

Need 3 approvals from the current 5 maintainers:

@dlorenc

dlorenc commented Apr 29, 2022

Copy link
Copy Markdown

Strong +1!

@sudo-bmitch

Copy link
Copy Markdown
Contributor

Thank you @jdolitsky! I'd be happy to accept this if approved by the maintainers.

@vbatts

vbatts commented Apr 29, 2022 via email

Copy link
Copy Markdown
Member

jonjohnsonjr
jonjohnsonjr previously approved these changes Apr 29, 2022
@jonjohnsonjr

Copy link
Copy Markdown
Contributor

LGTM

@sajayantony

Copy link
Copy Markdown
Member

+1.

jdolitsky added 2 commits May 10, 2022 10:05
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
@jdolitsky

Copy link
Copy Markdown
Contributor Author

something happened w/ DCO stuff, did not intend to "dismiss stale reviews"

@jdolitsky

Copy link
Copy Markdown
Contributor Author

For CI failure, see #916

@vbatts

vbatts commented May 12, 2022

Copy link
Copy Markdown
Member

rebase pls

@jdolitsky

Copy link
Copy Markdown
Contributor Author

I've updated the issue description to follow the new template

@estesp

estesp commented Jul 29, 2022

Copy link
Copy Markdown
Contributor

@stevvooe @cyphar @jonboulle would be great to get votes up or down on this candidate for maintainer. If we have maintainers who feel they can't vote then it would be great to understand what additional information would be helpful to make a decision. Thanks!

@jdolitsky

Copy link
Copy Markdown
Contributor Author

ping

@vbatts vbatts left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💚

@jdolitsky

Copy link
Copy Markdown
Contributor Author

Thanks all. I think this is good to merge

@jdolitsky

Copy link
Copy Markdown
Contributor Author

pingity ping pong ping ping

@vbatts

vbatts commented Aug 9, 2022

Copy link
Copy Markdown
Member

just went over the governance again, and not recalling whether there is special procedure for bringing on maintainers.
(whether it's 2 LGTMs; simple majority; or 2/3 majority)
ping @caniszczyk @amye

@tianon

tianon commented Aug 9, 2022

Copy link
Copy Markdown
Member

See opencontainers/runtime-spec#1150 (comment) for a semi-recent analysis of that from the perspective of the runtime-spec repository (I'm guessing the image-spec repo is in a similar place and likely has a very similar repo governance doc).

@vbatts

vbatts commented Aug 9, 2022

Copy link
Copy Markdown
Member

@tianon thanks for that.

@vbatts

vbatts commented Aug 10, 2022

Copy link
Copy Markdown
Member

As this has 2/3 quorum of current maintainers (and has been opened for at least five days), this is a go!

Welcome @sudo-bmitch !

@vbatts
vbatts merged commit 2014771 into opencontainers:main Aug 10, 2022
@vbatts vbatts mentioned this pull request Aug 10, 2022
5 tasks
@vbatts

vbatts commented Aug 10, 2022

Copy link
Copy Markdown
Member

@jonboulle

Copy link
Copy Markdown
Contributor

lgtm! thanks brandon for your contributions over the years.

@cyphar

cyphar commented Aug 11, 2022

Copy link
Copy Markdown
Member

FWIW, LGTM. I'm on vacation so didn't see the previous pings. Thanks for joining us Brandon!

@caniszczyk

caniszczyk commented Oct 11, 2022 via email

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.