Repository navigation
feat: resolve guest links into file listing - #3816
Merged
Merged
Conversation
JammingBen
force-pushed
the
feat/guest-full-ui
branch
from
October 15, 2026 12:20
cffcfc0 to
21ee7ec
Compare
JammingBen
force-pushed
the
feat/guest-full-ui
branch
from
October 15, 2026 12:52
21ee7ec to
6ee9ce6
Compare
JammingBen
force-pushed
the
feat/guest-full-ui
branch
4 times, most recently
from
October 15, 2026 14:03
7aaeabf to
52f5d08
Compare
JammingBen
force-pushed
the
feat/guest-full-ui
branch
from
October 16, 2026 06:12
52f5d08 to
a827a01
Compare
8 tasks
JammingBen
marked this pull request as ready for review
October 16, 2026 06:49
Member
Author
|
|
JammingBen
marked this pull request as draft
October 16, 2026 07:17
AlexAndBear
reviewed
Oct 16, 2026
Member
There was a problem hiding this comment.
Remaining frontend differences (compared to public link context):
- Upload-only: New → Markdown creates an empty file (
201), then opens it read-only without Save. Public links hide document creation for this permission. The creation guard only checks public spaces. - Viewer: Guests get Copy to and Save as, but every destination is unwritable. Public viewers hide both. The copy guard assumes authenticated users have a writable home; the Save as guard allows every non-public context.
- Single-file invitations: Save as is also offered without an accessible destination folder. Public single-file links hide it.
Please apply the corresponding permission/destination checks to guests.
Additional backend/session limitations to document, beyond those already listed in the PR (tested with rolling 8.1.0+40095460):
- Office:
/app/openand/app/newreturn401with a valid guest cookie; equivalent public links return200. Both paths are missing from the backend guest-auth allowlist. This also affects the Collabora-based secure PDF viewer. - Parallel invitations: Opening Guest B in another tab replaces Guest A's session. Reloading A requires invitation renewal; two public links remain usable in parallel.
- Whole project spaces: Adding a guest reports success and creates membership, but emits
SpaceSharedwithoutGuestTokenCreated, so no invitation token is generated. A public link to the same space root works.
Member
|
Exploratory browser testing found two additional issues. Approval stands — please fix these in a follow-up PR.
Tested at |
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Guest links now open the file listing, scoped to the share the guest was invited to.
Known limitations
These are backend limitations. The UI doesn't hide the affected actions, because backend support is planned:
More general limitations:
Issue
closes #2825
Fixes #3831
How to test
docker run --rm --network container:web_oc natsio/nats-box nats -s nats://127.0.0.1:9233 sub main-queue --raw | jq --unbuffered -r 'select(.Metadata.eventtype | test("GuestTokenCreated")) | .Payload | @base64d | fromjson | .Token'