Repository navigation
feat(admin-settings): search users by user name and email as well - #3517
Merged
AlexAndBear merged 2 commits intoOct 1, 2026
Merged
Conversation
AlexAndBear
force-pushed
the
fix/admin-settings-users-search-username-and-mail
branch
from
October 1, 2026 07:45
ed1eea0 to
44bc58f
Compare
AlexAndBear
changed the base branch from
fix/admin-settings-avatar-in-name-column
to
main
October 1, 2026 07:45
Member
Author
|
wait until #3516 is merged |
AlexAndBear
force-pushed
the
fix/admin-settings-users-search-username-and-mail
branch
from
October 1, 2026 12:18
44bc58f to
b2cb7b4
Compare
Member
Author
resolved ✅ |
JammingBen
approved these changes
Oct 1, 2026
AlexAndBear
deleted the
fix/admin-settings-users-search-username-and-mail
branch
October 1, 2026 12:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The user search of the admin settings only searched the display name: it sent
$filter=contains(displayName,'…'), so searching for a user name or an email address returned no users (e.g. the useralexwith the display name "dragan").The Graph API of OpenCloud supports
$searchfor users, which matches the display name, the user name and the email (substrings, case-insensitive). The search now uses it, like the user search of the share dialog in the files app (useCollaboratorSearch) already does:$search="…"instead ofcontains(displayName,'…')in$filter; the group and role filters stay in$filter$searchand$filtercan be combinedAlice Han,alice-1db,web.de) are rejected with a 400; a double quote can't be escaped inside the quoted termq_displayName, so existing links keep working#3516 moves the avatar into the user name column as well; whichever PR is merged second needs a small rebase of that cell.
Screenshots
Searching for the user name
alex(display name "dragan"):Related Issue
How Has This Been Tested?
pnpm vitedev server against the docker-compose backend, Playwright, unit tests with Vitest$searchfinds users by display name, user name, email and substrings, case-insensitive, also combined with amemberOffilter;contains()ononPremisesSamAccountNameormailandorcombinations return no usersalex(user name),drag(display name),web.de(email),Alice Han(space) andalice-1db(dash) find the expected users, the term is highlighted in the matching columnweb-app-admin-settings,pnpm check:types, lint and format passTypes of changes