Repository navigation
feat: redesign admin user and group edit panels - #3489
Merged
Merged
Conversation
JammingBen
approved these changes
Sep 30, 2026
openclouders
pushed a commit
that referenced
this pull request
Sep 30, 2026
* feat: redesign admin user and group edit panels * fix: increase spacing between user edit panel sections * fix: align user details sidebar with edit form order
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Redesigns the edit panels for users and groups in the admin settings and simplifies the code behind the Revert/Save dialog.
Screenshots
Layout
OcSelectdidn't give its message line a height, sofix-message-linehad no effect when the line was empty. It now uses the samemt-1 min-h-4.5asOcTextInput. Why: all fields have the same vertical rhythm.Code
CompareSaveDialogused to subscribe tosidebar.entity.saved, and the edit panels published that event after saving. The dialog now gets asavedprop (v-model:saved). Why: the state is local to the panel, and the dialog no longer reacts to saves from anywhere else in the app. Its two watchers for resetting the state are gone too.TagsSelectpublishedsidebar.entity.saved, but nothing was listening to it.UserInfoBoxandGroupInfoBoxwere no longer registered after the sidebar header refactoring and only rendered as unknown elements. The tags and the files are removed.EditPaneluses<script setup>: it was a mix of Options API andsetup()with anemitsthat was never emitted. Why: it now follows the project conventions and matches the Users panel.userdirectly instead of acloneDeepcopy, andinvalidFormDatausessome().OcTextInputPasswordcopied itsvalueprop into a local ref only once, so resetting it from outside had no effect. It now syncs changes ofvalue.Notes for reviewers
CompareSaveDialogandOcSelectare part of the publicweb-pkg/design-systempackages. Extensions that publishedsidebar.entity.savedto show "Changes saved" need to pass thesavedprop instead, and selects withfix-message-lineor a description now get the same message-line spacing as text inputs.formData.*.validstays, because it keeps Save disabled while the async "already exists" check is running.flex-1 flex-coldown to the panel component, so sub-panels can fill the height. I checked the file sharing panel, which looks unchanged.Related Issue
How Has This Been Tested?
savedprop and its timeout inCompareSaveDialogand for syncing the value inOcTextInputPassword; the full unit test suite, type check, lint and format passTypes of changes