Skip to content

feat: remove actions panel from right sidebar - #3484

Merged
AlexAndBear merged 2 commits into
mainfrom
fix/remove-sidebar-actions-panel
Sep 29, 2026
Merged

AlexAndBear merged 2 commits into
mainfrom
fix/remove-sidebar-actions-panel

Conversation

@AlexAndBear

@AlexAndBear AlexAndBear commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

Description

Removes the "Actions" panel from the right sidebar in all three places:

  • Files app: the actions panel for files/folders
  • Files app: the space-actions panel for project spaces
  • Admin settings: the SpaceActions panel in the spaces sidebar

Why this is better

Resource and space actions already live in one place: the context menu (right click, the "…" button in the resource table, and the space header context menu). The sidebar panel showed the same actions a second time, one level down behind a panel switch. That gives users two places to look for the same thing and doesn't let them do anything they couldn't already do.

It also costs us maintenance. Every action had to be registered on an extra sidebar extension point (app.files.sidebar.actions, app.admin-settings.spaces.sidebar-actions) as well as the context menu, and the two lists could drift apart. With the panel gone, the context menu is the only place users find actions.

Code changes

  • Removed the sidebar panel registrations in useFileSideBars.ts and Spaces.vue (admin settings)
  • Deleted ActionsPanel.vue (admin settings) and its unit test
  • Removed the app.admin-settings.spaces.sidebar-actions extension point and all registrations on it
  • Removed space action registrations that only existed for the sidebar panel (edit readme, upload/set/delete space image). They are still available through the "Customize" submenu in the space context menu.
  • Removed the now-unused "close bottom drawer on sidebar action click" handling in SideBar.vue
  • FileActions.vue stays, because the single-resource details view (ResourceDetails.vue) still uses it

E2E tests

  • Helpers that went through the sidebar actions panel (delete, download, copy/move, favorite, open in media viewer, create from template, available-actions checks, space actions) now use the context menu
  • Steps renamed from "using the sidebar panel" to "using the context menu" where they covered actions; copy/move uses the existing dropdown-menu variant
  • Removed the duplicated "context menu" block in spaces/project.feature, because both variants now run the same code path
  • Removed the a11y check for the actions panel

Related Issue

  • Fixes: no issue filed

How Has This Been Tested?

  • test environment: local, macOS
  • pnpm test:unit --run for web-app-files, web-app-admin-settings and the web-pkg sidebar (all passing)
  • pnpm check:types, pnpm lint, pnpm format:check
  • e2e: type check and lint of tests/e2e pass; the e2e suite has not been run against a backend yet (CI)

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear AlexAndBear self-assigned this Sep 29, 2026
@AlexAndBear

Copy link
Copy Markdown
Member Author

@tbsbdr @kulmann this might be controversial, but I see no reason to have this in, please make a decision

@github-project-automation github-project-automation Bot moved this to Qualification in OpenCloud Team Board Sep 29, 2026
@AlexAndBear AlexAndBear added Type:Maintenance E.g. technical debt, packaging, etc. and removed Type:Bug labels Sep 29, 2026
@tbsbdr

tbsbdr commented Sep 29, 2026

Copy link
Copy Markdown
Member

iirc this is a leftover from the very early oc web ui when we had no right-click. lets remove it and see if someone complains.

@tbsbdr tbsbdr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AlexAndBear

Copy link
Copy Markdown
Member Author

iirc this is a leftover from the very early oc web ui when we had no right-click. lets remove it and see if someone complains.

🤗

@AlexAndBear
AlexAndBear merged commit 9ea337b into main Sep 29, 2026
31 checks passed
@AlexAndBear
AlexAndBear deleted the fix/remove-sidebar-actions-panel branch September 29, 2026 14:40
@AlexAndBear AlexAndBear removed the Type:Maintenance E.g. technical debt, packaging, etc. label Sep 29, 2026
@AlexAndBear AlexAndBear changed the title fix: remove actions panel from right sidebar feat: remove actions panel from right sidebar Sep 29, 2026
@openclouders openclouders mentioned this pull request Sep 29, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants