Repository navigation
feat(office-settings): polish fonts table to match overall design - #3479
Merged
Merged
Conversation
Use oc-table with sorting by name and a search filter like the apps table, align the heading with the account settings, add a subtitle, a breadcrumb link and an allowed file types hint for the upload input, and clear the upload input after uploading.
AlexAndBear
force-pushed
the
enhancement/polish-office-fonts-table
branch
from
September 29, 2026 06:43
6131822 to
f640cdc
Compare
fschade
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Polishes the office settings fonts page so it matches the overall design of the admin and account settings:
oc-table(like the apps table in the admin settings), sortable by name, with the sort state kept in the route query.ttf,.otf)FontsListcomponent and theFonttype intotypes.tsvue-routerto the package'speerDependencies, like the other appsBefore
After
Related Issue
How Has This Been Tested?
pnpm viteagainst the docker-compose backend), Chromeoc-tableand can be sorted by name ascending/descendingFontsList(filtering, empty state, sorting, highlighting, delete event) andApptests (incl. upload clears the input) passTypes of changes