Skip to content

feat(files): use NoContentMessage for resource not found message - #3447

Merged
kulmann merged 1 commit into
mainfrom
refactor/files-not-found-no-content-message
Sep 24, 2026
Merged

kulmann merged 1 commit into
mainfrom
refactor/files-not-found-no-content-message

Conversation

@AlexAndBear

@AlexAndBear AlexAndBear commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

Description

The "Resource not found" message in the files list had its own hand-built layout. It now uses the shared NoContentMessage component, like the other empty states and the 404 page.

  • It shows the 404.svg empty-state image in place of the cloud icon.
  • The title goes in the message slot. The explanation and the navigation buttons (Spaces overview, Personal page, Reload public link) go in the callToAction slot.
  • The wrapper id and button ids are unchanged, so the existing selectors keep working.

Related Issue

  • Fixes <issue_link>

How Has This Been Tested?

  • test environment: local, Vitest
  • test case 1: NotFoundMessage.spec.ts passes (button visibility and routes for the personal and public link routes)
  • test case 2: ESLint and Prettier pass on the changed files

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear
AlexAndBear force-pushed the refactor/files-not-found-no-content-message branch from 35e9bcd to e1f0633 Compare September 24, 2026 06:53
@AlexAndBear AlexAndBear changed the title refactor(files): use NoContentMessage for resource not found message fix(files): use NoContentMessage for resource not found message Sep 24, 2026
@AlexAndBear
AlexAndBear requested a review from kulmann September 24, 2026 06:53
@github-project-automation github-project-automation Bot moved this to Qualification in OpenCloud Team Board Sep 24, 2026
@AlexAndBear AlexAndBear moved this from Qualification to In Progress in OpenCloud Team Board Sep 24, 2026
@kulmann
kulmann merged commit e8517e4 into main Sep 24, 2026
33 checks passed
@kulmann
kulmann deleted the refactor/files-not-found-no-content-message branch September 24, 2026 11:41
@openclouders openclouders mentioned this pull request Sep 24, 2026
1 task
@AlexAndBear AlexAndBear changed the title fix(files): use NoContentMessage for resource not found message feat(files): use NoContentMessage for resource not found message Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants