Skip to content

feat: always sort folders above files - #3411

Merged
kulmann merged 1 commit into
mainfrom
fix/folders-always-on-top
Sep 21, 2026
Merged

kulmann merged 1 commit into
mainfrom
fix/folders-always-on-top

Conversation

@AlexAndBear

@AlexAndBear AlexAndBear commented Sep 19, 2026 •

Copy link
Copy Markdown
Member

Description

Folders now always come first when sorting by name. Before, the folder and file groups were concatenated in sort direction, so descending put files first and folders at the bottom. The direction now only orders within each group.

Related Issue

How Has This Been Tested?

  • test environment: local, pnpm test:unit --run, pnpm check:types, pnpm lint, pnpm format:check
  • test case 1: ascending by name keeps folders on top
  • test case 2: descending by name keeps folders on top, reversed within each group

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

Sorting by name grouped folders and files, but concatenated the groups
in sort direction: descending put files first and pushed folders to the
bottom. The direction now only orders within each group.
@AlexAndBear AlexAndBear self-assigned this Sep 19, 2026
@AlexAndBear

Copy link
Copy Markdown
Member Author

@kulmann @tbsbdr needs PM decision

@kulmann kulmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that's a good finding. Not preserving the two groups would probably be received as a bug since there's no other file cloud which flips the two groups when reversing the sort order.

@kulmann
kulmann merged commit 98c43a3 into main Sep 21, 2026
32 checks passed
@kulmann
kulmann deleted the fix/folders-always-on-top branch September 21, 2026 07:20
@openclouders openclouders mentioned this pull request Sep 21, 2026
1 task
@AlexAndBear AlexAndBear changed the title Always sort folders above files fix: always sort folders above files Sep 29, 2026
@AlexAndBear AlexAndBear changed the title fix: always sort folders above files feat: always sort folders above files Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants