Repository navigation
Remove the vault unlock actions and hide the lock action for disabled spaces - #3404
Merged
Merged
Conversation
AlexAndBear
force-pushed
the
vault-actions-on-disabled-space
branch
from
September 18, 2026 06:31
fb93b99 to
a913018
Compare
AlexAndBear
changed the title
Entering a locked vault already routes to the scheme's unlock UI through the router guard, so the separate "Unlock space" and "Unlock vault" context actions only duplicated that path and had to be kept in sync with it. Both are gone; unlocking happens by navigating in. What remains is the lock action, which is now hidden for disabled spaces: a disabled space cannot be entered, so offering to lock its vault led nowhere. The guard runs after the selection check, otherwise an empty selection would dereference an undefined space.
AlexAndBear
force-pushed
the
vault-actions-on-disabled-space
branch
from
September 18, 2026 06:33
a913018 to
ec98451
Compare
kulmann
approved these changes
Sep 18, 2026
kulmann
left a comment
kulmann
left a comment
Member
There was a problem hiding this comment.
Nice!
One additional thing that contextually fits in here, but I can also open a separate issue: I noticed that an unlocked space doesn't get auto-locked when disabling the space. Want me to open another issue for it?
Member
Author
yes please |
github-project-automation
Bot
moved this from In Progress
to Done
in OpenCloud Team Board
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Entering a locked vault already routes to the scheme's unlock UI via the router guard (
setupVaultUnlockGuard), so the separateUnlock space/Unlock vaultcontext actions only duplicated that path - They are removed entirely: unlocking now happens by navigating into the space or folder.What remains is the lock action, which is now hidden for disabled spaces. A disabled space cannot be entered, so offering to lock its vault led nowhere.
Related Issue
No issue was filed for this.
How Has This Been Tested?
pnpm test:unit --run packages/web-app-filespnpm check:types,pnpm lintandpnpm format:checkpass; 760 tests inweb-app-filespassTypes of changes