Skip to content

Guest invite - #2915

Merged
kulmann merged 9 commits into
mainfrom
guest-invite
Sep 29, 2026
Merged

Guest invite#2915
kulmann merged 9 commits into
mainfrom
guest-invite

Conversation

@kulmann

@kulmann kulmann commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Adds guest invites from entered, valid email addresses.

Related Issue

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@kulmann
kulmann added this pull request to stack #3339 September 9, 2026 12:29
@kulmann
kulmann force-pushed the guest-invite branch 2 times, most recently from 298afb5 to e97087a Compare September 21, 2026 12:41
kulmann
kulmann commented Sep 21, 2026
View reviewed changes
Comment thread ...es/src/components/SideBar/Shares/Collaborators/InviteCollaborator/InviteCollaboratorForm.vue Outdated

const isSpace = !unref(resource) || isSpaceResource(unref(resource))
const guests = isSpace
const contacts = isSpace

@kulmann kulmann Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renaming OX addressbook users to contacts because our own email invite flow is supposed to be the guests.

@kulmann
kulmann force-pushed the guest-invite branch 4 times, most recently from 500b4d8 to 4fbc09b Compare September 22, 2026 09:37
@kulmann
kulmann marked this pull request as ready for review September 22, 2026 10:03
@AlexAndBear

AlexAndBear commented Sep 22, 2026

Copy link
Copy Markdown
Member

It looks like the icons in the invite box are black for guest users
image

Also I am not a fan of globe icon in general, do we have other options ?

@AlexAndBear

AlexAndBear commented Sep 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
image

The orange color of the globe icon is visually not very pleasing

@AlexAndBear

AlexAndBear commented Sep 22, 2026

Copy link
Copy Markdown
Member

When I set the share type to external and add a guest user with the role can edit, the share will be created with the role can view, is this somehow expected ?

@AlexAndBear

AlexAndBear commented Sep 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Typing an email inside the Share with People box is very hard, when there is already an account present, without the auto-complete for guest users, it's even harder - nearly to "unsuable" :(

image

@AlexAndBear

AlexAndBear commented Sep 27, 2026

Copy link
Copy Markdown
Member

@kulmann I fixed the little ui inconveniences. There is still to discuss what to do with the external share issue. Maybe disable guests for the external share as @JammingBen proposed ?

Other than that Lgtm 👍

@kulmann

kulmann commented Sep 28, 2026

Copy link
Copy Markdown
Member Author

Also I am not a fan of globe icon in general, do we have other options ?

Globe icon was the wish and command of @tbsbdr

@kulmann

kulmann commented Sep 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Typing an email inside the Share with People box is very hard, when there is already an account present, without the auto-complete for guest users, it's even harder - nearly to "unsuable" :(

image

How did you manage to have typing the new email address on the same row as the already existing pill? It's always a new line for me. ah, you fixed it already. nice! 💪

@kulmann
kulmann requested a review from JammingBen September 28, 2026 13:52
@kulmann
kulmann merged commit 1d0a280 into main Sep 29, 2026
31 checks passed
@kulmann
kulmann deleted the guest-invite branch September 29, 2026 07:30
openclouders pushed a commit that referenced this pull request Sep 29, 2026
@kulmann
Merge pull request #2915 from opencloud-eu/guest-invite
739d796 
Guest invite
@openclouders openclouders mentioned this pull request Sep 29, 2026
Merged
1 task
@kulmann kulmann mentioned this pull request Oct 5, 2026
Closed
@v-scharf v-scharf mentioned this pull request Oct 5, 2026
Merged
@Svanvith Svanvith mentioned this pull request Oct 26, 2026
Open
4 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexAndBear AlexAndBear AlexAndBear approved these changes
@tammi-23 tammi-23 Awaiting requested review from tammi-23
@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees

No one assigned

Labels

Type:Enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Guests] Invite guests by email address from the Sharing / Members panel

3 participants

@kulmann @AlexAndBear @JammingBen