Skip to content

fix(guest): propfind sharetype - #918

Merged
maki5 merged 2 commits into
opencloud-eu:mainfrom
maki5:fix/propfind_sharetype
Oct 28, 2026
Merged

maki5 merged 2 commits into
opencloud-eu:mainfrom
maki5:fix/propfind_sharetype

Conversation

@maki5

@maki5 maki5 commented Oct 26, 2026

Copy link
Copy Markdown

@maki5
maki5 requested review from aduffeck and rhafer October 27, 2026 10:25

@aduffeck aduffeck left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kulmann does web already handy type 4 or does it need to be adjusted?

The backend side looks good to me.

@maki5
maki5 merged commit ba73828 into opencloud-eu:main Oct 28, 2026
19 checks passed
@kulmann

kulmann commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

@kulmann does web already handy type 4 or does it need to be adjusted?

The backend side looks good to me.

type 4 is currently being handled.. but maybe @tbsbdr wants to have a dedicated guest share indicator in the file list? (or, unrelated to the webdav share type, a dedicated "Shared with guests" page in the shares section?)

butonic added a commit to butonic/reva that referenced this pull request Oct 28, 2026
workpackages merged opencloud-eu#906 as e541dac, which left this branch with two
merge bases (the 2.52.1 release and the opencloud-eu#906 head). git resolves that
cleanly, but GitHub reports the PR as conflicting. Merging back collapses
the history to a single base and brings in the guest share type for
propfind (opencloud-eu#918).

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants