Skip to content

UserEqual and UserIDEqual ignore Type value of the UserId #788

Open

Description

@rhafer

Currently, when checking CS3 user or userid objects for equality we ignore the Type field of the UserId. Also we're ignoring the Idp value when comparing UserId. See the utils.UserEqual and utils.UserIDEqual helpers.

Even if there might be a reason for this (I don't know), this looks wrong. We should either fix that to document the reasons for this.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions