Skip to content

fix(search): engine wrapper which handles panics - #3854

Open
maki5 wants to merge 1 commit into
opencloud-eu:mainfrom
maki5:fix/catch_search_panics
Open

maki5 wants to merge 1 commit into
opencloud-eu:mainfrom
maki5:fix/catch_search_panics

Conversation

@maki5

@maki5 maki5 commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

closes: #3796

The panic is coming internal from bleve, the fix catches the panics on the search package level, for this specific issue might be an overkill, but I think since there is some uncontrolled calls to third party tools like bleve or opensearch which can panic it's better to prevent them all instead of waiting for a potential issue

@maki5
maki5 requested review from aduffeck and rhafer October 28, 2026 15:54
@codacy-production

codacy-production Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 50 complexity

Metric Results
Complexity 50

View in Codacy

🟢 Coverage 39.51% diff coverage · +0.02% coverage variation

Metric Results
Coverage variation ✅ +0.02% coverage variation (-1.00%)
Diff coverage ✅ 39.51% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (83615f2) 92640 25418 27.44%
Head commit (1db08ea) 92722 (+82) 25462 (+44) 27.46% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3854) 81 32 39.51%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Search panics on disk-write failure and crashes the entire all-in-one process

1 participant