Repository navigation
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
21c216a to
a036625
Compare
aduffeck
left a comment
aduffeck
left a comment
There was a problem hiding this comment.
Something's broken with the reva bump apparently.
| case strconv.Itoa(int(storageprovider.GranteeType_GRANTEE_TYPE_GROUP)): | ||
| types = append(types, "group") | ||
| case strconv.Itoa(int(conversions.ShareTypeGuest)): | ||
| types = append(types, "user") |
There was a problem hiding this comment.
Should we "unique" the types before returning them? Not sure what web does when an item is shared with a user and a guest and gets ["user", "user"] as a result.
There was a problem hiding this comment.
from what I understood web handles guest as user, but I might be wrong, @kulmann can you correct me?
There was a problem hiding this comment.
deduplication would be good and I would expect guest in line 640, not user.
handle new ShareTypeGuest on GetDriveItem
closes: #3592
related to: opencloud-eu/libre-graph-api#83