Skip to content

[stable-7.2] fix empty call to action translations - #3833

Merged
v-scharf merged 1 commit into
stable-7.2from
backport/stable-7.2/pr-3789
Oct 27, 2026
Merged

v-scharf merged 1 commit into
stable-7.2from
backport/stable-7.2/pr-3789

Conversation

@micbar

@micbar micbar commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

Backport of the translate() fix from #3789. Emails without a call to action (share expired, membership expired, ScienceMesh) got the .po header appended in every translated language, gotext returns it for an empty string.

Fixes #3830 on stable-7.2. Regression test with a German ShareExpired.

@github-actions github-actions Bot added this to the next-stable milestone Oct 27, 2026
@codacy-production

codacy-production Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 4 complexity

Metric Results
Complexity 4

View in Codacy

🟢 Coverage 68.42% diff coverage · +0.11% coverage variation

Metric Results
Coverage variation ✅ +0.11% coverage variation (-1.00%)
Diff coverage ✅ 68.42% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6f49f86) Report Missing Report Missing Report Missing
Head commit (ce0d7ce) 82088 (+5) 19059 (+95) 23.22% (+0.11%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3833) 19 13 68.42%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

1 Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@micbar
micbar force-pushed the backport/stable-7.2/pr-3789 branch from 2ee7f9e to ce0d7ce Compare October 27, 2026 11:00
@micbar
micbar requested review from aduffeck and v-scharf October 27, 2026 11:00
@micbar

micbar commented Oct 27, 2026

Copy link
Copy Markdown
Member Author

@v-scharf This is a possible backport, the problem is described in #3830

@v-scharf

Copy link
Copy Markdown
Contributor

@micbar @schweigisito @Svanvith
here I described process:

Screenshot 2026-10-27 at 12 30 31

@micbar micbar changed the title [stable-7.2] ci: remove per-repo S3 cache purge. run save-pipeline-in… [stable-7.2] fix empty call to action translations Oct 27, 2026
@micbar

micbar commented Oct 27, 2026

Copy link
Copy Markdown
Member Author

This is already the backport PR

@v-scharf
v-scharf merged commit 5463e22 into stable-7.2 Oct 27, 2026
55 of 56 checks passed
@v-scharf
v-scharf deleted the backport/stable-7.2/pr-3789 branch October 27, 2026 15:05
@openclouders openclouders mentioned this pull request Oct 27, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: German translation metadata (PO header) appended to share revocation email body

3 participants