Repository navigation
tests: add acceptance tests for renewing guest links - #3753
Merged
Merged
Conversation
Up to standards ✅🟢 Issues
|
v-scharf
force-pushed
the
test/guest-links-renew
branch
from
October 19, 2026 09:54
ed923a4 to
7469990
Compare
v-scharf
force-pushed
the
test/guest-links-security
branch
from
October 19, 2026 09:54
32a6d33 to
9ef1380
Compare
v-scharf
force-pushed
the
test/guest-links-renew
branch
from
October 19, 2026 10:20
7469990 to
11cb25a
Compare
v-scharf
force-pushed
the
test/guest-links-security
branch
from
October 19, 2026 12:18
9ef1380 to
52863c4
Compare
v-scharf
force-pushed
the
test/guest-links-renew
branch
2 times, most recently
from
October 19, 2026 12:52
9fbe668 to
38a2e38
Compare
v-scharf
force-pushed
the
test/guest-links-security
branch
from
October 19, 2026 12:53
52863c4 to
357d3a8
Compare
v-scharf
force-pushed
the
test/guest-links-renew
branch
2 times, most recently
from
October 20, 2026 07:22
ed8ce22 to
12718b3
Compare
Cover renewing a guest link with and without a session, the PIN, rate limiting and the expiry of the session and the PIN.
v-scharf
force-pushed
the
test/guest-links-renew
branch
from
October 20, 2026 07:24
12718b3 to
895b558
Compare
maki5
reviewed
Oct 20, 2026
maki5
approved these changes
Oct 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers renewing a guest link with and without a session, the PIN, rate limiting and the expiry of the session and the PIN (short lifetimes are set through the ocwrapper)