Repository navigation
chore(deps): update Vite toolchain - #124
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed August 8, 2026, 11:59 PM ET / August 9, 2026, 03:59 UTC. ClawSweeper reviewWhat this changesUpdates Vite to 8.2.1, refreshes its resolved Rolldown and PostCSS packages, and explicitly declares the Emscripten runtime peer used by the native build CLI. Merge readiness⛔ Blocked until stronger real behavior proof is added - 2 items remain This is a focused, coherent toolchain update with no code-level defect found. It should remain open for normal review; the remaining blocker is verifiable after-fix package-smoke evidence, not a repair to the patch. Priority: P3 Review scores
Verification
How this fits togetherThe build and test toolchain compiles the package and its native binding, then exercises package and filesystem-boundary checks before release. Vite/Vitest and the native CLI feed those checks without changing the package’s public filesystem APIs. flowchart LR
A[Package source] --> B[Build and test toolchain]
C[Native CLI runtime peer] --> B
B --> D[Native binding build]
B --> E[Filesystem boundary tests]
D --> F[Package smoke check]
E --> F
F --> G[Release artifact]
Before merge
Agent review detailsSecurityNone. Review metrics
Technical reviewBest possible solution: Keep the explicit peer dependency and merge once a redacted real package-smoke transcript confirms the native-required artifact still reads and writes within its root while rejecting traversal. Do we have a high-confidence way to reproduce the issue? Not applicable: this PR updates development tooling rather than reporting a reproducible runtime defect. Is this the best way to solve the issue? Yes, the exact direct peer declaration and generated lockfile update are the narrow maintainable response to the changed Vite resolution. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against d08e8593c56a. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
|
Landed as 0e0c90c. Verification:
|
Summary
@napi-rs/cliafter Vite stopped supplying it transitivelyVerification
pnpm check— 1,035 tests plus docs/build/package and boundary checks passedpnpm native:build— release native binding compiled and staged successfullypnpm outdated --format list— no remaining updatesoutside-workspace