Skip to content

chore(deps): update Vite toolchain - #124

Merged
steipete merged 1 commit into
mainfrom
chore/update-vite-8.2.1
Aug 9, 2026
Merged

steipete merged 1 commit into
mainfrom
chore/update-vite-8.2.1

Conversation

@steipete

@steipete steipete commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • update Vite from 8.2.0 to 8.2.1 with its Rolldown and PostCSS patch updates
  • declare the exact Emscripten runtime peer required by @napi-rs/cli after Vite stopped supplying it transitively
  • record the toolchain refresh in the unreleased changelog

Verification

  • pnpm check — 1,035 tests plus docs/build/package and boundary checks passed
  • pnpm native:build — release native binding compiled and staged successfully
  • pnpm outdated --format list — no remaining updates
  • built package in native-required mode wrote/read through a disposable root and rejected traversal with outside-workspace
  • Codex autoreview — clean, no accepted/actionable findings

@steipete
steipete requested a review from a team as a code owner August 9, 2026 03:55
@clawsweeper clawsweeper Bot added rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. labels Aug 9, 2026
@steipete
steipete merged commit 0e0c90c into main Aug 9, 2026
27 checks passed
@steipete
steipete deleted the chore/update-vite-8.2.1 branch August 9, 2026 04:00
@clawsweeper clawsweeper Bot added the P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. label Aug 9, 2026
@clawsweeper

clawsweeper Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs real behavior proof before merge. Reviewed August 8, 2026, 11:59 PM ET / August 9, 2026, 03:59 UTC.

ClawSweeper review

What this changes

Updates Vite to 8.2.1, refreshes its resolved Rolldown and PostCSS packages, and explicitly declares the Emscripten runtime peer used by the native build CLI.

Merge readiness

⛔ Blocked until stronger real behavior proof is added - 2 items remain

This is a focused, coherent toolchain update with no code-level defect found. It should remain open for normal review; the remaining blocker is verifiable after-fix package-smoke evidence, not a repair to the patch.

Priority: P3
Reviewed head: cbbf5a9b2b8015ec735a064490c16bcd1e2f738d

Review scores

Measure Result What it means
Overall readiness 🦐 gold shrimp (3/6) The dependency update is focused and appears correct, but maintainers still need observable real package-smoke evidence before merge.
Proof confidence 🦐 gold shrimp (3/6) Needs stronger real behavior proof before merge: The PR describes a successful real package smoke run, but provides no terminal output, log, recording, or linked artifact that independently shows the after-fix native-required traversal rejection. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Verification

Check Result Evidence
Real behavior Needs proof Needs stronger real behavior proof before merge: The PR describes a successful real package smoke run, but provides no terminal output, log, recording, or linked artifact that independently shows the after-fix native-required traversal rejection. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.
Evidence reviewed 5 items Focused dependency diff: The branch changes only the changelog, manifest, and lockfile; it pins Vite 8.2.1 and adds the explicit @emnapi/runtime development dependency.
Resolved peer and toolchain graph: The updated lockfile resolves @napi-rs/cli with @emnapi/runtime 2.0.0-alpha.3 and updates Vite’s direct Rolldown and PostCSS resolutions to 1.2.3 and 8.5.26.
Patch integrity: The complete three-file diff has no whitespace errors.
Findings None None.
Security None None.

How this fits together

The build and test toolchain compiles the package and its native binding, then exercises package and filesystem-boundary checks before release. Vite/Vitest and the native CLI feed those checks without changing the package’s public filesystem APIs.

flowchart LR
  A[Package source] --> B[Build and test toolchain]
  C[Native CLI runtime peer] --> B
  B --> D[Native binding build]
  B --> E[Filesystem boundary tests]
  D --> F[Package smoke check]
  E --> F
  F --> G[Release artifact]
Loading

Before merge

  • Add real behavior proof - Needs stronger real behavior proof before merge: The PR describes a successful real package smoke run, but provides no terminal output, log, recording, or linked artifact that independently shows the after-fix native-required traversal rejection. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.
  • Complete next step (P2) - The submitted patch needs contributor-supplied real package-smoke proof before a human merge decision; there is no discrete code repair for an automation lane.
Agent review details

Security

None.

Review metrics

Metric Value Why it matters
Changed surface 3 files: 1 manifest, 1 lockfile, 1 changelog The update is confined to the declared development toolchain and its generated resolution.
Lockfile resolution 88 added, 123 removed lines The resolution refresh updates Vite 8.2.0 to 8.2.1 and its transitive toolchain packages without source changes.

Technical review

Best possible solution:

Keep the explicit peer dependency and merge once a redacted real package-smoke transcript confirms the native-required artifact still reads and writes within its root while rejecting traversal.

Do we have a high-confidence way to reproduce the issue?

Not applicable: this PR updates development tooling rather than reporting a reproducible runtime defect.

Is this the best way to solve the issue?

Yes, the exact direct peer declaration and generated lockfile update are the narrow maintainable response to the changed Vite resolution.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against d08e8593c56a.

Labels

Label changes:

  • add P3: This is routine build-tooling maintenance with no reported runtime regression or public API change.
  • add rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
  • add status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask. Needs stronger real behavior proof before merge: The PR describes a successful real package smoke run, but provides no terminal output, log, recording, or linked artifact that independently shows the after-fix native-required traversal rejection. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.

Label justifications:

  • P3: This is routine build-tooling maintenance with no reported runtime regression or public API change.
  • rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
  • status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask. Needs stronger real behavior proof before merge: The PR describes a successful real package smoke run, but provides no terminal output, log, recording, or linked artifact that independently shows the after-fix native-required traversal rejection. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.

Evidence

What I checked:

  • Focused dependency diff: The branch changes only the changelog, manifest, and lockfile; it pins Vite 8.2.1 and adds the explicit @emnapi/runtime development dependency. (package.json:155, cbbf5a9b2b80)
  • Resolved peer and toolchain graph: The updated lockfile resolves @napi-rs/cli with @emnapi/runtime 2.0.0-alpha.3 and updates Vite’s direct Rolldown and PostCSS resolutions to 1.2.3 and 8.5.26. (pnpm-lock.yaml:2002, cbbf5a9b2b80)
  • Patch integrity: The complete three-file diff has no whitespace errors. (cbbf5a9b2b80)
  • Recent package provenance: The proposed commit is directly based on current main; current main’s latest package release history includes the v0.5.2 release commit by the same recent toolchain contributor. (package.json:165, 32759e8923a1)
  • Repository policy: Repository policy requires lockfiles to be generated rather than edited manually and requires an Unreleased changelog entry for package or operational changes; both are present in the submitted patch. (AGENTS.md:35, d08e8593c56a)

Likely related people:

  • steipete: Authored this dependency refresh and the recent v0.5.2 release commit in the package’s available history. (role: recent package and release contributor; confidence: medium; commits: cbbf5a9b2b80, 32759e8923a1; files: package.json, pnpm-lock.yaml, CHANGELOG.md)

Rank-up moves

Optional improvements that raise the rating; they are not merge blockers.

  • Add a redacted terminal transcript or artifact from the native-required packaged-root write/read and traversal-rejection smoke run; updating the PR body will trigger fresh review.

Rating scale

Score Internal tier Crab rank Meaning
6/6 S 🦀 challenger crab Exceptional readiness
5/6 A 🦞 diamond lobster Very strong readiness
4/6 B 🐚 platinum hermit Good normal PR; ordinary maintainer review
3/6 C 🦐 gold shrimp Useful, but confidence is limited
2/6 D 🦪 silver shellfish Proof or implementation needs work
1/6 F 🧂 unranked krab Not merge-ready
N/A NA 🌊 off-meta tidepool Rating does not apply

Overall follows the weaker of proof and patch quality.
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Workflow

  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@steipete

steipete commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

Landed as 0e0c90c.

Verification:

  • reviewed Vite 8.2.1 release notes and lockfile transitive changes
  • declared @emnapi/runtime 2.0.0-alpha.3 explicitly to satisfy @napi-rs/cli after Rolldown stopped supplying that peer transitively
  • pnpm check passed: 1,035 tests plus docs/build/package and boundary checks
  • pnpm native:build compiled and staged the release native binding
  • native-required live package smoke wrote/read successfully and rejected traversal with outside-workspace
  • pnpm outdated --format list reports no remaining updates
  • all 27 exact-head checks completed green, including Windows, native, audit, coverage, package-smoke, and CodeQL lanes
  • Codex autoreview was clean with no accepted/actionable findings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant