chore(backend): float Docker base back to node:22 now that 22.23.1 ships the fix#657
Conversation
…ips the fix Node 22.23.1 (nodejs/node#64004) reverts the keep-alive socket-reuse regression that 22.23.0's CVE-2026-48931 fix introduced, so the temporary node:22.22 pin is no longer needed. The node-fetch@2 premature-close failure on internal service-to-service calls (catalog -> permission) no longer reproduces on 22.23.1+. Signed-off-by: Kavith Lokuhewage <kaviththiranga@gmail.com>
📝 WalkthroughWalkthroughThis PR updates the backend Dockerfile to use floating ChangesBackend Node 22 unpin
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/backend/Dockerfile`:
- Around line 55-64: The Dockerfile only documents the Node 22.23.1 minimum, but
`build-image` can still use a cached `node:22-bookworm-slim` below that floor.
Update the backend image flow by adding an explicit runtime version check in
`packages/backend/Dockerfile` around the `FROM node:22-bookworm-slim` stage so
the build fails unless Node is at least 22.23.1, and consider aligning
`build-image` in `packages/backend/package.json` to pull a fresh base image so
the cached image cannot bypass the minimum patch requirement.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 8c1e4138-7a19-4c7a-9e57-06516e5b61e9
📒 Files selected for processing (2)
.changeset/unpin-node-22-22.mdpackages/backend/Dockerfile
Node 22.23.1 (nodejs/node#64004) reverts the keep-alive socket-reuse
regression that 22.23.0's CVE-2026-48931 fix introduced, so the temporary
node:22.22 pin is no longer needed. The node-fetch@2 premature-close failure
on internal service-to-service calls (catalog -> permission) no longer
reproduces on 22.23.1+.
Summary by CodeRabbit