Remove treatment data upload to NS entries - #288
Merged
scottleibrand merged 1 commit intoDec 26, 2016
Conversation
The treatment history data is already uploaded to NS's treatments collection, so it does not need to also go to the entries collection. Additionally, it causes problems when backfilling sgv to the entries collection.
This was referenced Dec 26, 2016
scottleibrand
approved these changes
Dec 26, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes pump history upload to the Nightscout entries collection.
Reasons for the change:
recent-missing-entriesalgorithm does not distinguish between sensor and pump history data in the entries collection. This causes the algorithm to think there are no sgv gaps if there is history data around the same time, event though those items are being uploaded independently of each other. This causes valid sgv entries to be removed from the NS upload incorrectly, resulting in gaps.Relevant PRs:
openaps/decocare#16
#287