Skip to content

Wip/min thresholds - #40

Merged
scottleibrand merged 3 commits into
devfrom
wip/min-thresholds
Oct 18, 2015
Merged

Wip/min thresholds#40
scottleibrand merged 3 commits into
devfrom
wip/min-thresholds

Conversation

@scottleibrand

Copy link
Copy Markdown
Contributor

Add sanity checks to prevent min_bg and max_bg from being set too low, or min_bg being set too high. (We can safely allow max_bg to be too high: openaps just won't do anything.)

@bewest

bewest commented Oct 17, 2015

Copy link
Copy Markdown
Member

We should also check that the if (bgtargera.units !== "mg/dL") { throw "bad units, we only do mg/dL"; } or something.

@scottleibrand

Copy link
Copy Markdown
Contributor Author

@oskarpearson please test the unit check with both mmol/L and mg/dL units. if it fails properly in the mmol/L case and works normally with mg/dL, I think we can merge.

@bewest

bewest commented Oct 17, 2015

Copy link
Copy Markdown
Member

I've fixed some of the problems in the last set of patches in #39, would like to get this into dev.

@scottleibrand
scottleibrand merged commit 513a89c into dev Oct 18, 2015
@scottleibrand
scottleibrand deleted the wip/min-thresholds branch October 18, 2015 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants