Skip to content

Decode additional bit in insulin sensitivity - #23

Merged
scottleibrand merged 1 commit into
openaps:devfrom
ecc1:dev
Jul 17, 2017
Merged

Decode additional bit in insulin sensitivity#23
scottleibrand merged 1 commit into
openaps:devfrom
ecc1:dev

Conversation

@ecc1

@ecc1 ecc1 commented Mar 8, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@ecc1

ecc1 commented Mar 8, 2017

Copy link
Copy Markdown
Contributor Author

This is an UNTESTED fix for #21

@scottleibrand

Copy link
Copy Markdown
Contributor

Anyone available to test this? @tmecklem, @Bender1061, @cjo20 ?

@scottleibrand

Copy link
Copy Markdown
Contributor

@ecc1 do you know what range of sensitivities should work before and after this change? Wondering if @Kdisimone could test this one like she did #28

@ecc1

ecc1 commented Jul 11, 2017

Copy link
Copy Markdown
Contributor Author

Maximum correctly-decoded sensitivities should be 255 before the change, 511 after the change (but model 522 limits it to 400, and I think 523 limits it to 500)

@Kdisimone

Kdisimone commented Jul 11, 2017

Copy link
Copy Markdown

sure I could. I have been doing the work around of installing the updated decocare...that's worked too easy_install -U decocare

related #25

@scottleibrand

Copy link
Copy Markdown
Contributor

Just pushed an ecc1-dev branch to make this easier to test. If anyone else (@SebastienLussier @ceben80 @Missdazzle @PieterGit) could help test this one as well, please do.

@Kdisimone

Copy link
Copy Markdown

tested, works on 523

before fix
screen shot 2017-07-16 at 12 44 38 pm

after fix

screen shot 2017-07-16 at 12 51 49 pm

@Kdisimone

Copy link
Copy Markdown

btw, carb ratios fix is in there too...looks good

@Kdisimone

Copy link
Copy Markdown

And lastly, the 523 only allows up to 400 for isf in the bolus wizard settings.

@scottleibrand

Copy link
Copy Markdown
Contributor

Anyone else want to test this, or should I go ahead and merge it to dev?

@Kdisimone

Copy link
Copy Markdown

@scottleibrand I'd merge it at this point. I tested on a 723 as well and it worked great

@scottleibrand
scottleibrand merged commit d2b33ca into openaps:dev Jul 17, 2017
@jcwarrior

Copy link
Copy Markdown

Tested on 754. Max pump ISF is 400 and decoding right after fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants