Skip to content

Fix sorting of #/components/schemas/* - #50

Merged
langecode merged 1 commit into
openapi-tools:masterfrom
hiddewie:fix-deterministic-sort-schemas
Jul 3, 2020
Merged

Fix sorting of #/components/schemas/*#50
langecode merged 1 commit into
openapi-tools:masterfrom
hiddewie:fix-deterministic-sort-schemas

Conversation

@hiddewie

@hiddewie hiddewie commented Jul 3, 2020

Copy link
Copy Markdown
Contributor

There was a regression in e629216 (#49) that caused the result of sortSchemas not to be used.

This regression made schemas non sorted.

A test has been added and the fix has been done.

@langecode

Copy link
Copy Markdown
Member

Doh. Thanks. I think I have time to quickly create a new release now.

@langecode
langecode merged commit c4fb402 into openapi-tools:master Jul 3, 2020
@UnHumbleBen

Copy link
Copy Markdown

@hiddewie Thanks for the PR's made for this! Just wondering if there are plans to handle schemas that are not embedded in components (schemas defined in parameters). Seems like this issue has been noted here: swagger-api/swagger-core#3613 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants