chore(spindle-ui): set base font family#8
Merged
Merged
Conversation
Contributor
|
baseで設定すべき内容なのでComponent単位で指定ではなく・・ですよね。 |
Member
Author
|
そうそう、こりはあくまでStorybook内での指定という感じです!共通部分の実装が決まれば取り除いてもいいかもだね。 共通部分に関しては・・・ font-familyなどサイト間で違ってほしくないものは、まとめて共通CSS(ameba-color-palette.cssの上位版? or spindle.base.css or theme-ameba.css)作って読み込んでもらってもいいかなぁと思い中です。 rootのフォントサイズはサイトによって違ってもよさそうなのとすでに今違いそうなので、以下を検討してるけどどうだろかな。
|
1 task
Contributor
よさそうです! たしかにcomponentとしてはem指定のがよさそうですね。
だけでも十分そうな気もしますが、念のため・・?? |
Member
Author
|
フォントサイズに関しては、検討案はORでした(分かりづらく申し訳w)!ので、カスタムプロパティは必要に応じてにしましょう〜。 |
This was referenced Aug 17, 2020
Closed
1 task
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Storybookのプレビュー内では、Spindleで規定されたフォントでコンポーネントを表示するようにします。