docs(spindle-ui): add Design Doc for Breadcrumb#770
Merged
Conversation
|
✨✨ That's perfect, there is no visual difference! ✨✨ Check out the report here. |
Contributor
|
Visit the preview URL for this PR (updated for commit 43e520f): https://ameba-spindle--pr770-docs-breadcrumb-kbhzzbq4.web.app (expires Fri, 08 Sep 2023 05:36:33 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e7521619a2dd5c653490c8246e81ec2a5c8f1435 |
itsminadesu
reviewed
Aug 7, 2023
herablog
reviewed
Aug 7, 2023
yasuda-shin
reviewed
Aug 7, 2023
| - [現在位置を確認することができる](https://a11y-guidelines.ameba.design/2/4/8/)[SHOULD] | ||
| - [ ] 現在位置は `aria-current="page"` を付与している | ||
| - [ターゲットのサイズを理解する](https://a11y-guidelines.ameba.design/2/5/5/)[SHOULD] | ||
| - [ ] タップ領域は44px以上確保している※注 |
Contributor
There was a problem hiding this comment.
Suggested change
| - [ ] タップ領域は44px以上確保している※注 | |
| - [ ] タップ領域は44px × 44px以上確保している※注 |
ちょっと細かいですが 44px × 44px と明記した方がよかったりします？
Contributor
Author
There was a problem hiding this comment.
マスターシート＆コンポーネントのシート＆Design Docsも反映しました！ a6ddf5e
（マスターシートをいじる必要があるのは初期だけと信じている・・w）
tokimari
force-pushed
the
docs/breadcrumb
branch
from
00f80b6 to
bb530a1
Compare
herablog
reviewed
Aug 8, 2023
itsminadesu
reviewed
Aug 8, 2023
itsminadesu
left a comment
itsminadesu
left a comment
Contributor
There was a problem hiding this comment.
細かいとこだけ追加でコメントしましたが、良さそうです 🎉
Contributor
Author
|
#770 (comment) についてはいい案が浮かばずいったんステイ・・ひとまず概要のままでどうでしょうか:joy: |
tokimari
force-pushed
the
docs/breadcrumb
branch
from
a2ba152 to
43e520f
Compare
Contributor
Author
|
コミットまとめました！ |
Contributor
Author
|
球場から・・！？ :arigatogozaimasu: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breadcrumb ComponentのDesign Docを移行してみました。
移行元のDesign Doc、参照したFigmaファイルはasanaのチケットに貼ります:pray:
きになり
## スクリーンショットに追加すべきものが思い浮かばなかったので削除しましたが、なにか入れるべきだったでしょうか・・ 🤔