Skip to content

Allow callers to control prompt cache keys independently of session IDs - #55587

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/f9e8ab31fcf568636f9712726760e4e9a4672428
Oct 20, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/f9e8ab31fcf568636f9712726760e4e9a4672428

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Allow callers to control prompt cache keys independently of session IDs

What changed

Expose PromptCacheKey through StartThreadOptions with three policies: retain the default session-derived key, send a custom key, or omit prompt_cache_key from model requests. Keep session identity headers independent of this policy.

Propagate the policy to child agents, delegated sessions, and guardian review sessions. Hosts must reapply the policy when resuming a thread from storage.

Testing

Add coverage for all three policies across turns, including unchanged session and thread headers. Extend subagent coverage to verify inheritance of the default and omitted-key policies.

…Ds (#55587)

## What changed

Expose `PromptCacheKey` through `StartThreadOptions` with three policies: retain the default session-derived key, send a custom key, or omit `prompt_cache_key` from model requests. Keep session identity headers independent of this policy.

Propagate the policy to child agents, delegated sessions, and guardian review sessions. Hosts must reapply the policy when resuming a thread from storage.

## Testing

Add coverage for all three policies across turns, including unchanged session and thread headers. Extend subagent coverage to verify inheritance of the default and omitted-key policies.

GitOrigin-RevId: f9e8ab31fcf568636f9712726760e4e9a4672428
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/f9e8ab31fcf568636f9712726760e4e9a4672428 branch from 851787b to ab6095d Compare October 20, 2026 14:15
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-20T14:15:12.265619Z 851787b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@copyberry
copyberry Bot merged commit ab6095d into main Oct 20, 2026
39 of 71 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/f9e8ab31fcf568636f9712726760e4e9a4672428 branch October 20, 2026 14:15
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 20, 2026

This branch was previously deployed

1 inactive deployment
issue-triage — ab6095dd Deployed Oct 20, 2026 by mbtz via Identify potential duplicates (open issues fallback) #57264
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants