Repository navigation
Preserve incoming prompts when pre-turn compaction fails - #44487
Merged
copyberry[bot] merged 1 commit intoSep 10, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why Pre-turn compaction runs before incoming input is recorded, so failures could leave an accepted prompt out of conversation history. Reporting the error before prompt hooks finish also lets clients steer follow-up input into a turn still preserving its prompt. ## What changed Record input and run prompt hooks on every pre-turn compaction failure. Defer local and remote compaction error events to `run_turn`, after prompt preservation completes, while retaining the remote error prefix. ## Testing Extend the remote compaction output-validation test to trigger automatic compaction and assert that the prompt is emitted before the error, saved exactly once, and followed by no additional model request. Retain the assertion that usage is recorded for invalid compaction output. GitOrigin-RevId: ab7ccb259836c084173e0e81dbbd4c610e95a6c8
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/ab7ccb259836c084173e0e81dbbd4c610e95a6c8
branch
from
September 10, 2026 10:08
5b302a1 to
ee93abb
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/ab7ccb259836c084173e0e81dbbd4c610e95a6c8
branch
September 10, 2026 10:08
michkot
temporarily deployed
to
issue-triage
September 10, 2026 10:23 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
michkot
temporarily deployed
to
issue-triage
September 10, 2026 10:23 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
michkot
temporarily deployed
to
issue-triage
September 10, 2026 10:23 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
michkot
temporarily deployed
to
issue-triage
September 10, 2026 10:24 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve incoming prompts when pre-turn compaction fails
Why
Pre-turn compaction runs before incoming input is recorded, so failures could leave an accepted prompt out of conversation history. Reporting the error before prompt hooks finish also lets clients steer follow-up input into a turn still preserving its prompt.
What changed
Record input and run prompt hooks on every pre-turn compaction failure. Defer local and remote compaction error events to
run_turn, after prompt preservation completes, while retaining the remote error prefix.Testing
Extend the remote compaction output-validation test to trigger automatic compaction and assert that the prompt is emitted before the error, saved exactly once, and followed by no additional model request. Retain the assertion that usage is recorded for invalid compaction output.