Fail closed on unsafe Linux unreadable globs - #38026
Merged
copyberry[bot] merged 1 commit intoAug 11, 2026
Merged
Conversation
## Why Linux sandbox unreadable globs without a non-root directory prefix cannot be safely expanded because they would require scanning from `/`. Silently skipping these patterns leaves the requested deny-read rule unenforced. ## What changed Return a fatal sandbox construction error when an unreadable glob cannot be split into a safe ripgrep search root. The error directs callers to use a pattern with a non-root directory prefix. ## Testing Add a regression test confirming that `/**/*.env` rejects Bubblewrap command construction. GitOrigin-RevId: 2f3cb398d39a9bc077d3a1b74e08dc506d239e60
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/2f3cb398d39a9bc077d3a1b74e08dc506d239e60
branch
from
August 11, 2026 15:54
7aa22bc to
1dac3d9
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/2f3cb398d39a9bc077d3a1b74e08dc506d239e60
branch
August 11, 2026 15:55
TyceHerrman
temporarily deployed
to
issue-triage
August 11, 2026 15:58 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
TyceHerrman
temporarily deployed
to
issue-triage
August 11, 2026 15:58 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
TyceHerrman
temporarily deployed
to
issue-triage
August 11, 2026 15:58 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
TyceHerrman
temporarily deployed
to
issue-triage
August 11, 2026 15:59 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
clinton550i
temporarily deployed
to
issue-triage
August 11, 2026 16:12 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
clinton550i
temporarily deployed
to
issue-triage
August 11, 2026 16:12 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
clinton550i
temporarily deployed
to
issue-triage
August 11, 2026 16:12 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
clinton550i
temporarily deployed
to
issue-triage
August 11, 2026 16:13 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
a497771654
temporarily deployed
to
issue-triage
August 11, 2026 16:15 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
a497771654
temporarily deployed
to
issue-triage
August 11, 2026 16:15 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
a497771654
temporarily deployed
to
issue-triage
August 11, 2026 16:15 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fail closed on unsafe Linux unreadable globs
Why
Linux sandbox unreadable globs without a non-root directory prefix cannot be safely expanded because they would require scanning from
/. Silently skipping these patterns leaves the requested deny-read rule unenforced.What changed
Return a fatal sandbox construction error when an unreadable glob cannot be split into a safe ripgrep search root. The error directs callers to use a pattern with a non-root directory prefix.
Testing
Add a regression test confirming that
/**/*.envrejects Bubblewrap command construction.