Repository navigation
Read rollout reference histories - #27968
Closed
friel-openai wants to merge 5 commits into
Closed
friel-openai wants to merge 5 commits into
friel-openai wants to merge 5 commits into
Conversation
Separate bounded model replay from fallible complete-history reconstruction, validate immutable segment resolution, and make app-server, search, memory, and feedback readers reference-aware.
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2852e3b9d1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
|
Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RolloutReferenceItemwire format and immutableSegmentIdreader support.Context
This is the reader prerequisite split from #27249 after review identified persistence and rotation concerns in that PR. Existing Frodex rollouts already contain
rollout_referenceand legacyfork_referenceitems, so decoding and read compatibility are useful independently of enabling Session segmentation.This PR does not declare the Session segmentation feature and has no production
RolloutReferenceItemconstructor. It does not add a database migration. The serialized fields, defaults, andfork_referencealias are unchanged from #27249 atffbd02abb5.Read contracts
segment_idis authoritative. Resolution validates the target file'sSessionMeta.segment_idand does not fall back to a same-named live file with different content.The feature flag, per-thread writer transaction, atomic canonical-file replacement, immutable reference publication, and reachability-based deletion belong to writer follow-up #27249.
Test plan
RUST_MIN_STACK=8388608 cargo test -p codex-rollout(85 passed)RUST_MIN_STACK=8388608 cargo test -p codex-thread-store(80 passed)RUST_MIN_STACK=8388608 cargo test -p codex-app-server-protocol(228 unit and 2 schema fixture tests passed)RUST_MIN_STACK=8388608 cargo test -p codex-memories-write(36 passed)RUST_MIN_STACK=8388608 cargo test -p codex-app-server --lib(248 passed)RUST_MIN_STACK=8388608 cargo test -p codex-core thread_rollout_truncation::tests(20 passed)thread/resume, unloadedthread/read, feedback attachment, interrupted-fork, and identity-validation fixture tests passedjust fixfor the six changed crates