Skip to content

Bound state log payloads - #23275

Closed
jif-oai wants to merge 1 commit into
mainfrom
jif/bound-log-db-fields
Closed

jif-oai wants to merge 1 commit into
mainfrom
jif/bound-log-db-fields

Conversation

@jif-oai

@jif-oai jif-oai commented May 18, 2026

Copy link
Copy Markdown
Contributor

Why

LogDbLayer is the durable boundary for SQLite diagnostic log storage. Bounding individual call sites is brittle and misses future tracing events.

What Changed

  • Cap formatted event fields, span fields, event message, and feedback log bodies to 16 KiB before queueing LogEntry rows.
  • Stream DefaultFields formatting through a bounded writer so large Debug/Display fields do not allocate an unbounded formatted string for the log DB path.
  • Avoid formatting non-thread_id fields in the thread-id visitors.

Verification

  • cargo test -p codex-state log_db
  • cargo test -p codex-state
  • just fmt
  • just fix -p codex-state

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant