Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
144 commits
Select commit Hold shift + click to select a range
be4812a
add guardian assessment thread items
charley-oai Mar 7, 2026
7f753e0
neutralize guardian denied history wording
charley-oai Mar 7, 2026
374fc9c
simplify guardian assessment tui handling
charley-oai Mar 7, 2026
e252426
neutralize guardian approval actor wording
charley-oai Mar 7, 2026
8ce553b
neutralize guardian assessment wording
charley-oai Mar 8, 2026
715abf4
restore schema eof newlines
charley-oai Mar 9, 2026
83a3981
document guardian assessment api as unstable
charley-oai Mar 9, 2026
8702529
fix guardian rebase fallout
charley-oai Mar 9, 2026
94647cd
remove dead guardian exec helper
charley-oai Mar 9, 2026
6fae374
redact denied guardian action payloads
charley-oai Mar 9, 2026
5c2b041
fallback guardian notifications to event turn id
charley-oai Mar 9, 2026
2b25193
fix app-server guardian assessment test
charley-oai Mar 9, 2026
9a5811b
fix clippy in guardian assessment test
charley-oai Mar 9, 2026
caa9c10
update guardian assessment generated fixtures
charley-oai Mar 9, 2026
9fc97b6
rename guardian feature to Smart Approvals and link menus
charley-oai Mar 9, 2026
21f33aa
hide Smart Approvals until feature is enabled
charley-oai Mar 9, 2026
ce20ae5
improve Smart Approvals feature description
charley-oai Mar 9, 2026
40759a3
add approval review policy config
charley-oai Mar 9, 2026
75197f9
Keep feature flag changes in experimental menu only
charley-oai Mar 9, 2026
521fa2e
Add history entries for Smart Approvals toggles
charley-oai Mar 9, 2026
453d15c
wire approval review policy through live overrides
charley-oai Mar 10, 2026
c1799e0
add approval review policy for smart approvals
charley-oai Mar 10, 2026
a740b6e
hide smart approvals when feature is disabled
charley-oai Mar 10, 2026
36c4b43
validate approval review policy against feature flag
charley-oai Mar 10, 2026
4a9d6d7
fix smart approvals feature toggle persistence
charley-oai Mar 10, 2026
42be6bf
fix exec approval review policy propagation
charley-oai Mar 10, 2026
5884590
rename remaining app-server guardian protocol helpers
charley-oai Mar 10, 2026
74d0266
normalize app-server approval state into tool items
charley-oai Mar 10, 2026
017f220
clear disabled feature flags in profile scope
charley-oai Mar 10, 2026
16de97f
tolerate missing cwd in guardian replay
charley-oai Mar 10, 2026
cf0cc1b
remove stale guardian app-server import
charley-oai Mar 10, 2026
b93b50c
fix feature flag lookup in config edits
charley-oai Mar 10, 2026
eaa8394
fix profile-scoped smart approvals toggles
charley-oai Mar 10, 2026
e635215
fix app-server approval status handling
charley-oai Mar 10, 2026
ef7c0c5
tui: apply smart approvals feature toggles immediately
charley-oai Mar 10, 2026
3086756
fix apply_patch guardian clippy
charley-oai Mar 10, 2026
e5ab4af
support concurrent guardian network approvals
charley-oai Mar 10, 2026
e755b6c
default session review policy in protocol
charley-oai Mar 10, 2026
ec2829d
fix rebased guardian test fallout
charley-oai Mar 10, 2026
3e12e2c
rename smart approvals feature key
charley-oai Mar 10, 2026
f237690
support string guardian command rendering
charley-oai Mar 10, 2026
98bf6a5
map guardian network actions into thread history
charley-oai Mar 10, 2026
8153da9
collapse network approval denial branch
charley-oai Mar 10, 2026
5799b46
update app-server file change approval tests
charley-oai Mar 10, 2026
6cde3e2
clarify smart approvals alias deprecation
charley-oai Mar 10, 2026
3a1b3a5
migrate guardian_approval to smart_approvals
charley-oai Mar 10, 2026
c0ed7e9
remove guardian_approval fallback alias
charley-oai Mar 10, 2026
3c32cf6
add app-server review policy conversions
charley-oai Mar 10, 2026
2acbb28
remove smart approvals config gate
charley-oai Mar 10, 2026
7022a0e
complete approved network review items
charley-oai Mar 10, 2026
9833bbb
fix stale mcp guardian callsites
charley-oai Mar 10, 2026
156f234
fix stale guardian mcp test
charley-oai Mar 10, 2026
81b12f2
complete approved network review updates
charley-oai Mar 10, 2026
b8387b6
fix smart approvals experimental toggle behavior
charley-oai Mar 10, 2026
c94913e
finish guardian assessment followups
charley-oai Mar 10, 2026
aae6063
separate guardian developer message
charley-oai Mar 10, 2026
179ff23
tone down guardian review status ui
charley-oai Mar 11, 2026
53f1659
sync review policy into approvals popup state
charley-oai Mar 11, 2026
c5fe4e8
clear guardian review wait after decision
charley-oai Mar 11, 2026
4700c5f
relax smart approvals preset matching
charley-oai Mar 11, 2026
ae24a46
fix stale protocol review policy tests
charley-oai Mar 11, 2026
23f1e08
update smart approvals preset test
charley-oai Mar 11, 2026
1786286
reconstruct guardian execve thread items
charley-oai Mar 11, 2026
2b63a9d
avoid string heuristics for guardian network items
charley-oai Mar 11, 2026
3ca2d16
update guardian snapshot and config schema
charley-oai Mar 11, 2026
59964ec
show parallel guardian reviews in tui
charley-oai Mar 11, 2026
e73c18c
minimize guardian assessment event payloads
charley-oai Mar 11, 2026
759a079
preserve profile feature disables
charley-oai Mar 11, 2026
b966fca
complete denied automatic approval items
charley-oai Mar 11, 2026
aa9dc37
ignore smart approvals flag in exec
charley-oai Mar 11, 2026
b590097
fix missing app-server mcp status import
charley-oai Mar 11, 2026
52192b4
clarify approval review policy docs
charley-oai Mar 11, 2026
7a980ac
replace item updated with auto review started notification
charley-oai Mar 11, 2026
74a9d01
avoid forcing default review policy override
charley-oai Mar 11, 2026
ebb907e
fix exec approval review policy tests
charley-oai Mar 11, 2026
fa0aca0
mark approval review app-server fields unstable
charley-oai Mar 11, 2026
3282efc
fix request user input turn id fallback
charley-oai Mar 11, 2026
a0fc25c
avoid duplicate mcp approval completions
charley-oai Mar 11, 2026
3efaf46
fix redundant clone in thread history test
charley-oai Mar 11, 2026
ce399a3
route delegated exec approvals through guardian
charley-oai Mar 11, 2026
51c27e4
accept snake_case review risk fields
charley-oai Mar 11, 2026
584f8ad
align auto approval review protocol with item lifecycles
charley-oai Mar 11, 2026
cda66a4
route delegated approvals through auto review
charley-oai Mar 11, 2026
f078987
fix delegated auto review clippy issues
charley-oai Mar 11, 2026
2a3b67a
route delegated MCP approvals through auto review
charley-oai Mar 11, 2026
3765a5d
fix stale codex_delegate test callsite
charley-oai Mar 11, 2026
fde84a9
nest auto approval review notification paths
charley-oai Mar 11, 2026
03128af
cancel delegated guardian reviews
charley-oai Mar 11, 2026
5c94f83
remove stale guardian import
charley-oai Mar 11, 2026
29f2f90
refactor thread history approval updates
charley-oai Mar 11, 2026
d5a650c
emit terminal event for cancelled auto review
charley-oai Mar 12, 2026
41b1809
send manual review policy override
charley-oai Mar 12, 2026
dbb6f4f
fix stale guardian test callsites after rebase
charley-oai Mar 12, 2026
e4f9740
gate mcp approval replay to approval prompts
charley-oai Mar 12, 2026
b7ac269
fix stale smart approvals fixtures
charley-oai Mar 12, 2026
260c0d0
add comment
charley-oai Mar 12, 2026
37708fd
Simplify guardian approval review notifications
charley-oai Mar 12, 2026
ff6a88c
Clarify approval review policy stability
charley-oai Mar 12, 2026
f1e4008
Clarify auto approval review docs
charley-oai Mar 12, 2026
b511c3b
Clarify guardian approval review flow
charley-oai Mar 13, 2026
af11872
Clarify approvals reviewer documentation
charley-oai Mar 13, 2026
63e94f6
Remove undeployed reviewer aliases
charley-oai Mar 13, 2026
d2ff6e7
Document guardian feature alias migration
charley-oai Mar 13, 2026
b8f4d68
Remove duplicate guardian apply patch changes payload
charley-oai Mar 13, 2026
4c40b41
Refine smart approvals feature description
charley-oai Mar 13, 2026
6ef07d6
Preserve network review turn ids in guardian events
charley-oai Mar 13, 2026
a297eec
Avoid reporting cancelled guardian reviews as denied
charley-oai Mar 13, 2026
c2666fe
Mirror guardian review events to ancestor threads
charley-oai Mar 13, 2026
a157346
Use command item ids for guardian exec reviews
charley-oai Mar 13, 2026
5c0920f
Render approved guardian reviews in TUI
charley-oai Mar 13, 2026
751fb2b
Emit terminal aborted guardian reviews
charley-oai Mar 13, 2026
edc06b3
Stabilize guardian review IDs and MCP approval strings
charley-oai Mar 13, 2026
cfcf476
Revert ancestor guardian review mirroring
charley-oai Mar 13, 2026
970f106
Include guardian action in review notifications
charley-oai Mar 13, 2026
fe72a3a
Preserve delegated MCP guardian denials
charley-oai Mar 13, 2026
24a3533
Attach action to approved guardian events
charley-oai Mar 13, 2026
adffb3b
Clarify parallel exec command results
charley-oai Mar 13, 2026
a1e9033
Stabilize guardian network review IDs
charley-oai Mar 13, 2026
47062dc
Clarify guardian developer prompt shaping
charley-oai Mar 13, 2026
9d091f9
Clarify guardian MCP decline token
charley-oai Mar 13, 2026
c0c931b
Tighten guardian status footer state
charley-oai Mar 13, 2026
59b998e
Clarify pending guardian footer state
charley-oai Mar 13, 2026
42ad4da
Fix default permissions snapshot selection
charley-oai Mar 13, 2026
642efe1
Fix core compile regressions
charley-oai Mar 13, 2026
c23285e
Document delegated MCP invocation cache
charley-oai Mar 13, 2026
0390248
Document delegated MCP guardian shim
charley-oai Mar 13, 2026
bf8e2a3
Extract smart approvals preset helper
charley-oai Mar 13, 2026
dc6e345
Fix unified exec suite parsing for command-prefixed output
charley-oai Mar 13, 2026
2c5e316
Align guardian approval docs with current behavior
charley-oai Mar 13, 2026
64535a1
Clarify guardian review persistence TODO
charley-oai Mar 13, 2026
b3b08cc
Soften smart approvals toggle comment
charley-oai Mar 13, 2026
1bf30ec
Clarify smart approvals toggle flow
charley-oai Mar 13, 2026
5f8f6fd
Tighten guardian footer status state
charley-oai Mar 13, 2026
5493472
Tighten guardian TUI state updates
charley-oai Mar 13, 2026
1bfde2f
Refine smart approvals TUI updates
charley-oai Mar 13, 2026
20f80c2
Inline guardian status helper
charley-oai Mar 13, 2026
7c7e157
Document guardian assessment handling
charley-oai Mar 13, 2026
656a280
Fix profile smart approvals disable guard
charley-oai Mar 13, 2026
0e682e5
Drop unshipped guardian background status path
charley-oai Mar 13, 2026
5b9bb7d
Migrate guardian alias to reviewer setting
charley-oai Mar 13, 2026
436bffb
Mark approvals reviewer config unstable and clean delegate flow
charley-oai Mar 13, 2026
919718b
Inline delegate approval await wrappers
charley-oai Mar 13, 2026
f0eebb6
Fix override turn context test initializers
charley-oai Mar 13, 2026
22eeedf
Fix stale core test helpers
charley-oai Mar 13, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 52 additions & 0 deletions codex-rs/app-server-protocol/schema/json/ClientRequest.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,14 @@
"description": "A path that is guaranteed to be absolute and normalized (though it is not guaranteed to be canonicalized or exist on the filesystem).\n\nIMPORTANT: When deserializing an `AbsolutePathBuf`, a base path must be set using [AbsolutePathBufGuard::new]. If no base path is set, the deserialization will fail unless the path being deserialized is already absolute.",
"type": "string"
},
"ApprovalsReviewer": {
"description": "Configures who approval requests are routed to for review. Examples include sandbox escapes, blocked network access, MCP approval prompts, and ARC escalations. Defaults to `user`. `guardian_subagent` uses a carefully prompted subagent to gather relevant context and apply a risk-based decision framework before approving or denying the request.",
"enum": [
"user",
"guardian_subagent"
],
"type": "string"
},
"AppsListParams": {
"description": "EXPERIMENTAL - list available apps/connectors.",
"properties": {
Expand Down Expand Up @@ -2508,6 +2516,17 @@
}
]
},
"approvalsReviewer": {
"anyOf": [
{
"$ref": "#/definitions/ApprovalsReviewer"
},
{
"type": "null"
}
],
"description": "Override where approval requests are routed for review on this thread and subsequent turns."
},
"baseInstructions": {
"type": [
"string",
Expand Down Expand Up @@ -2788,6 +2807,17 @@
}
]
},
"approvalsReviewer": {
"anyOf": [
{
"$ref": "#/definitions/ApprovalsReviewer"
},
{
"type": "null"
}
],
"description": "Override where approval requests are routed for review on this thread and subsequent turns."
},
"baseInstructions": {
"type": [
"string",
Expand Down Expand Up @@ -2939,6 +2969,17 @@
}
]
},
"approvalsReviewer": {
"anyOf": [
{
"$ref": "#/definitions/ApprovalsReviewer"
},
{
"type": "null"
}
],
"description": "Override where approval requests are routed for review on this thread and subsequent turns."
},
"baseInstructions": {
"type": [
"string",
Expand Down Expand Up @@ -3078,6 +3119,17 @@
],
"description": "Override the approval policy for this turn and subsequent turns."
},
"approvalsReviewer": {
"anyOf": [
{
"$ref": "#/definitions/ApprovalsReviewer"
},
{
"type": "null"
}
],
"description": "Override where approval requests are routed for review on this turn and subsequent turns."
},
"cwd": {
"description": "Override the working directory for this turn and subsequent turns.",
"type": [
Expand Down
145 changes: 145 additions & 0 deletions codex-rs/app-server-protocol/schema/json/ServerNotification.json
Original file line number Diff line number Diff line change
Expand Up @@ -1056,6 +1056,61 @@
},
"type": "object"
},
"GuardianApprovalReview": {
"description": "[UNSTABLE] Temporary guardian approval review payload used by `item/autoApprovalReview/*` notifications. This shape is expected to change soon.",
"properties": {
"rationale": {
"type": [
"string",
"null"
]
},
"riskLevel": {
"anyOf": [
{
"$ref": "#/definitions/GuardianRiskLevel"
},
{
"type": "null"
}
]
},
"riskScore": {
"format": "uint8",
"minimum": 0.0,
"type": [
"integer",
"null"
]
},
"status": {
"$ref": "#/definitions/GuardianApprovalReviewStatus"
}
},
"required": [
"status"
],
"type": "object"
},
"GuardianApprovalReviewStatus": {
"description": "[UNSTABLE] Lifecycle state for a guardian approval review.",
"enum": [
"inProgress",
"approved",
"denied",
"aborted"
],
"type": "string"
},
"GuardianRiskLevel": {
"description": "[UNSTABLE] Risk level assigned by guardian approval review.",
"enum": [
"low",
"medium",
"high"
],
"type": "string"
},
"HookCompletedNotification": {
"properties": {
"run": {
Expand Down Expand Up @@ -1253,6 +1308,56 @@
],
"type": "object"
},
"ItemGuardianApprovalReviewCompletedNotification": {
"description": "[UNSTABLE] Temporary notification payload for guardian automatic approval review. This shape is expected to change soon.\n\nTODO(ccunningham): Attach guardian review state to the reviewed tool item's lifecycle instead of sending separate standalone review notifications so the app-server API can persist and replay review state via `thread/read`.",
"properties": {
"action": true,
"review": {
"$ref": "#/definitions/GuardianApprovalReview"
},
"targetItemId": {
"type": "string"
},
"threadId": {
"type": "string"
},
"turnId": {
"type": "string"
}
},
"required": [
"review",
"targetItemId",
"threadId",
"turnId"
],
"type": "object"
},
"ItemGuardianApprovalReviewStartedNotification": {
"description": "[UNSTABLE] Temporary notification payload for guardian automatic approval review. This shape is expected to change soon.\n\nTODO(ccunningham): Attach guardian review state to the reviewed tool item's lifecycle instead of sending separate standalone review notifications so the app-server API can persist and replay review state via `thread/read`.",
"properties": {
"action": true,
"review": {
"$ref": "#/definitions/GuardianApprovalReview"
},
"targetItemId": {
"type": "string"
},
"threadId": {
"type": "string"
},
"turnId": {
"type": "string"
}
},
"required": [
"review",
"targetItemId",
"threadId",
"turnId"
],
"type": "object"
},
"ItemStartedNotification": {
"properties": {
"item": {
Expand Down Expand Up @@ -3706,6 +3811,46 @@
"title": "Item/startedNotification",
"type": "object"
},
{
"properties": {
"method": {
"enum": [
"item/autoApprovalReview/started"
],
"title": "Item/autoApprovalReview/startedNotificationMethod",
"type": "string"
},
"params": {
"$ref": "#/definitions/ItemGuardianApprovalReviewStartedNotification"
}
},
"required": [
"method",
"params"
],
"title": "Item/autoApprovalReview/startedNotification",
"type": "object"
},
{
"properties": {
"method": {
"enum": [
"item/autoApprovalReview/completed"
],
"title": "Item/autoApprovalReview/completedNotificationMethod",
"type": "string"
},
"params": {
"$ref": "#/definitions/ItemGuardianApprovalReviewCompletedNotification"
}
},
"required": [
"method",
"params"
],
"title": "Item/autoApprovalReview/completedNotification",
"type": "object"
},
{
"properties": {
"method": {
Expand Down
Loading
Loading