Skip to content

fix(plugin): pin the MCP formatter - #990

Merged
mldangelo-oai merged 1 commit into
mainfrom
mdangelo/codex/pin-mcp-formatter
Sep 22, 2026
Merged

mldangelo-oai merged 1 commit into
mainfrom
mdangelo/codex/pin-mcp-formatter

Conversation

@mldangelo-oai

Copy link
Copy Markdown
Collaborator

Summary

The MCP app needs its own pinned formatter when the plugin is installed without the SDK. Reusing the SDK's Prettier in #988 left standalone imports dependent on the host repository's formatter version.

Changes

  • Pin Prettier 3.9.6 in the MCP app and its lockfile.
  • Run the changed-file formatting check through the MCP app's dependencies.

Testing

  • Frozen dependency installation passed with lifecycle scripts disabled.
  • Ran the pinned formatter over the five affected MCP files; all were unchanged.
  • git diff --check passed.
  • Tests will run in CI, as requested. No local tests were run.

Risk and rollout

This changes development tooling and CI. The pinned version matches the formatter already used by the SDK. Runtime code and native build inputs are unchanged.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@github-actions github-actions Bot added the bug Something isn't working label Sep 22, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-22T01:07:31.450763Z 714d5a5 Manual request
🔒 Security Review ✅ Completed 2026-09-22T01:07:45.852076Z 714d5a5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review head 714d5a533cb7a4a9aeb6c72dd197fdda9b2ba1bb. This pins Prettier in the MCP app and makes its CI formatting check use that dependency. Tests are running in CI; no local tests were run.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 714d5a533c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@mldangelo-oai
mldangelo-oai merged commit a0ef227 into main Sep 22, 2026
72 checks passed
@mldangelo-oai
mldangelo-oai deleted the mdangelo/codex/pin-mcp-formatter branch September 22, 2026 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant