fix(plugin): keep model-authored runtime status out of finalized reports - #959
Closed
cstolting-collab wants to merge 1 commit into
Closed
cstolting-collab wants to merge 1 commit into
cstolting-collab wants to merge 1 commit into
Conversation
3 tasks
Collaborator
|
The original fix has now merged in #703. Closing this duplicate; thank you for refreshing and validating the change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #687.
Summary
Rebases the report-integrity fix from #703 onto current
main.The original implementation is by @russlan23. This branch preserves the minimal three-file solution: finalized Markdown reports no longer render model-authored
scan.scope.runtimeStatus, while manifest and draft-schema compatibility are unchanged.Changes
runtimeStatusinto generated Markdown reports.Validation
pnpm --dir sdk/typescript run build:ci: passed.git diff --check: passed.The full finalization test file ran 156 passed, 2 skipped, and 55 subtests passed, with one unrelated failure under the available Python 3.10: its
datetime.fromisoformatdoes not accept a trailingZ. The repository requires Python 3.12. Ruff was not run because the available Ruff version cannot parse the repository's pinnedRUF105configuration.Attribution
This branch rebases #703 and retains its implementation and regression coverage. A local CML evaluation used
ContinuityRegistryandContinuityProjectionto lock repository, revision, scope, plan, and candidate identity while recording evidence. CML did not generate the implementation or assess Python semantics; no CML runtime code is included.Risk and rollout
Low risk: deterministic Markdown presentation changes only. Finalizer-owned lifecycle fields, manifests, schemas, artifact digests, CLI behavior, and compatible consumers of
runtimeStatusare unchanged.Public disclosure review