fix(ci): tolerate transient setup failures and slow Windows runners - #953
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3d0b7cd904
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| encoding: "utf8", | ||
| env: constrainedEnvironment, | ||
| timeout: 15_000, | ||
| timeout: 60_000, |
There was a problem hiding this comment.
Raise the enclosing timeout with the child budgets
On a slow Windows runner, the three serial PowerShell probes can now consume up to 180 seconds, but .github/workflows/node-ci.yml still launches this test with bun test --timeout 120000; bun test --help describes that flag as “Set the per-test timeout in milliseconds.” Consequently, the runner can kill the second or third probe once the cumulative time reaches 120 seconds even though it has not exhausted its new 60-second child budget, so the intended tolerance is not fully effective. Increase the enclosing test timeout (and its workflow-contract assertion) to cover all serial probes and cleanup.
AGENTS.md reference: sdk/typescript/AGENTS.md:L35-L35
Useful? React with 👍 / 👎.
Summary
Recent
node-ciruns onmainfailed before their checks could finish: the Intel macOS runner could not resolve the Rust download host, Windows npm installation exceeded its three-minute timeout, and the Windows PowerShell language-mode probe exceeded its 15-second timeout. The extended runner comparison also rejected two parameterized tests whose boolean values were absent from their names.Failure logs: Rust download, Windows npm install, PowerShell probe, report comparison.
Changes
%jfor boolean test parameters so Bun emits distincttrueandfalsenames in JUnit reports.Testing
git diff --check: passed.12345): 3,075 passed, 57 skipped, no failures. Its complete JUnit report passes inventory validation.Risk and rollout
These changes affect CI setup, test budgets, and test report names. The Windows timeout increases mitigate observed deadline failures; the logs do not establish the cause of the intermittent slowness. Persistent failures can take longer to report. The PR's Windows jobs exercise machine-policy behavior and installed-package verification.
Public disclosure review