Skip to content

fix(plugin): bound source preview reads - #947

Merged
mluck-openai merged 2 commits into
mainfrom
codex/bound-source-preview-reads
Sep 17, 2026
Merged

mluck-openai merged 2 commits into
mainfrom
codex/bound-source-preview-reads

Conversation

@mluck-openai

Copy link
Copy Markdown
Collaborator

Summary

Repository ranking currently buffers entire text files to produce short source previews. Limit filesystem preview reads to 64 KiB by default, reusing the existing explicit-file budget.

Changes

  • Apply the shared default to repository, directory, explicit-file, and local-patch previews.
  • Include the initial binary-detection sample in the read budget and reject nonpositive limits.
  • Add large-text read-count regressions and coverage for truncated source, Unicode, binary detection, and overlapping scopes.

Testing

  • Focused preview, rank-input, and inventory tests: 152 passed.
  • Full Python suite: 1,109 passed, 8 skipped, and 109 subtests passed. One unchanged CLI-help test failed with inherited PYTHONSAFEPATH=1; its isolated rerun passed with that override unset.
  • Ruff lint and formatting checks passed.
  • TypeScript build:ci, plugin source compatibility checks, and all 9 compatibility-checker tests passed.
  • git diff --check passed.

Risk and rollout

Files larger than 64 KiB now produce previews from their prefix; later declarations and binary markers are not inspected. Explicit-file inclusion and the output preview budget are preserved. Committed-revision blob retrieval is outside this change. No release or version bump is included.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@github-actions github-actions Bot added the bug Something isn't working label Sep 17, 2026
@mluck-openai
mluck-openai marked this pull request as ready for review September 17, 2026 00:37
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-09-17T00:42:41.067475Z b891a7f Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mluck-openai
mluck-openai merged commit ead0ee9 into main Sep 17, 2026
53 checks passed
@mluck-openai
mluck-openai deleted the codex/bound-source-preview-reads branch September 17, 2026 00:42
@github-actions github-actions Bot mentioned this pull request Sep 17, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants