Skip to content

fix(logs): prefer complete saved rollout copies - #933

Merged
mldangelo-oai merged 4 commits into
mainfrom
mdangelo/codex/complete-scan-log-copies
Sep 16, 2026
Merged

mldangelo-oai merged 4 commits into
mainfrom
mdangelo/codex/complete-scan-log-copies

Conversation

@mldangelo-oai

@mldangelo-oai mldangelo-oai commented Sep 16, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Saved scan logs can select a truncated rollout even when a complete copy of the same session is available. Prefer the longer copy when the earlier events form an exact prefix.

Changes

  • Compare copies after metadata establishes scan membership.
  • Preserve repeated events, event order and existing precedence for identical or divergent copies; close both comparison iterators.
  • Give the boolean regression cases distinct JUnit names.

Testing

  • Unchanged main: 22 passes and two expected regression failures. Final head: all 24 cases pass in both orders; the JUnit comparison confirms distinct test identities.
  • Final head 4337ae09: both full Linux SDK runs pass with 3,034 tests, 50 skips and zero failures (seed 12345 and default seed 1391406740). Types, formatting and build pass.
  • Initial runs failed in the test environment. Controls reproduced ownership and checkout-ancestry problems on unchanged main; the passing runs use an isolated checkout. Original failures are retained, and not every earlier failure has a proven cause.
  • Three fresh native reviews, independent verification, hosted Codex review and platform CI pass at this head.

Risk and rollout

Additional reads are limited to selected duplicate logs. Public commands, event structure and scan membership retain their behavior. This PR remains separate from changes to log formatting or scan execution.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review head 4337ae0938f6ac1b313ce3990576bdbfc84a2450 against main 1a3ca64333f894426dde0c0a7721d717c99f8cba, including scan membership before copy comparison, strict event-prefix selection, repeated events and iterator cleanup.

@github-actions github-actions Bot added the bug Something isn't working label Sep 16, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-16T05:57:40.548647Z 4337ae0 Draft marked ready
🔒 Security Review ✅ Completed 2026-09-16T06:01:05.576714Z 4337ae0 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: 4337ae0938

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@mldangelo-oai
mldangelo-oai marked this pull request as ready for review September 16, 2026 05:55
@mldangelo-oai
mldangelo-oai merged commit 289f9d2 into main Sep 16, 2026
100 checks passed
@mldangelo-oai
mldangelo-oai deleted the mdangelo/codex/complete-scan-log-copies branch September 16, 2026 05:58
@github-actions github-actions Bot mentioned this pull request Sep 17, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant