fix(cli): show progress while patching findings - #931
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
I rebased and locally verified this change against current The only merge conflict was in Verification on the rebased candidate:
The focused suite was run; the full upstream suite and live cloud-agent execution were not run. No upstream branch, push, PR update, or merge was performed by this verification. |
|
I opened #950 with this PR rebased onto current |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 61221098a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
mldangelo-oai
left a comment
There was a problem hiding this comment.
Reviewed the refreshed head. The merge retains both the patch-progress regressions and the newer validation-prompt tests, and the implementation continues to reuse the existing presenter and timer. All 111 focused tests, types, build, and formatting pass. No blocking findings.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0e91c2e70f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
mldangelo-oai
left a comment
There was a problem hiding this comment.
Reviewed final head 80ff324. The four previous findings are fixed: runner diagnostics start after the timer, long titles fit terminal columns, reasoning summaries print once, and progress covers preparation through final file comparison. All 270 focused tests, types, build, formatting, and whitespace checks pass locally; Codex review reports no major issues on this head. No blocking findings. Full platform CI remains a separate merge gate.
Summary
After findings are approved for patching, the CLI can be silent until each patch finishes. Show the current finding, elapsed time, and live Codex activity so users can follow the work.
Changes
Testing
On head
80ff324:pnpm run types: passed.pnpm run build:ci: passed.pnpm run format: passed.git diff --check origin/main...HEAD: passed.The checks above use the SDK dependencies pinned by this branch. See GitHub checks for full-suite and platform results. No live model scan was run.
Risk and rollout
Low risk. This changes terminal progress using existing Codex events and flags. Progress display failures do not stop patching. No new public CLI options are introduced.
Public disclosure review