feat(cli): accept text knowledge-base files with any extension - #924
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
ianw-oai
approved these changes
Sep 14, 2026
mldangelo-oai
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--knowledge-baserejects JSON, SARIF, and other text files solely because of their extension. Accept UTF-8 text files with any extension, including extensionless files, through the existing CLI option and shared SDK loader.Changes
Testing
Validation before the help-text-only revert:
bun test --timeout 30000 tests-ts/knowledge-base.test.ts: 16 passed.pnpm run types: passed.pnpm run format: passed.pnpm run test: 2,996 passed, 50 skipped, 12 local environment failures. The failures came from unrelated parent-directory Git metadata in authentication tests and a Git-version difference in a malformed-config policy test; both reproduced on unchanged main. The two affected files passed on targeted reruns with system Git and separate working and temporary directories (60 authentication tests and 60 policy tests).4846c02, including Linux, macOS, Windows, installed-package checks, and security review.The follow-up restores
src/cli.tsexactly to the base version; its formatting check passed.Risk and rollout
Existing directory inputs will include text files that were previously ignored. No new commands, flags, or defaults are introduced. The shared loader also supplies policy generation and severity-classification context.
Public disclosure review