Skip to content

fix(deep): fence stale publication and preserve replay - #916

Draft
mldangelo-oai wants to merge 1 commit into
mainfrom
mdangelo/codex/phase1-stale-publication
Draft

mldangelo-oai wants to merge 1 commit into
mainfrom
mdangelo/codex/phase1-stale-publication

Conversation

@mldangelo-oai

Copy link
Copy Markdown
Collaborator

Summary

A replaced Deep coordinator can publish an obsolete aggregate over a newer result. Bind publication to the current coordinator generation and selected reducer result, and preserve replay when writing an already validated aggregate fails.

Changes

  • Carry host-selected generation and aggregate metadata through the coordinator and artifact adapter, separately from model-authored checkpoint data.
  • Check that metadata under the existing completion lock before changing checkpoints or canonical files. Preserve generation-one compatibility.
  • Keep a validated Deep publication replayable after output-write failure, retaining its original terminal cause and the existing publisher.
  • No schema migration, public CLI change, new runtime or retry layer.

Testing

On ef9e2ab03da7adb57b35cbd0f85d4690ec1f1b76:

  • Parent controls reproduce stale-publication and interrupted-replay failures; the corrected targeted Python suite passes all 24 cases.
  • Artifact adapter, coordinator and real-store tests pass, including propagation of host metadata without adding it to accepted checkpoint bytes.
  • Actual child-process exits at three file-write and two SQLite-commit boundaries preserve selected input and reject obsolete publication. Replay leaves completed bytes and finding occurrences unchanged.
  • Installed SDK controls pass with 25, 25 and 27 assertions; the physically detached plugin passes the same 24 publication/replay cases.
  • All five required portable checks, SDK/plugin builds and applicable type checks pass.
  • Independent composition with the checkpoint-recovery slice passes 44 targeted cases, with a second verification passing 45 including an additional existing control. Current-main source composition is clean. Native platform CI remains pending.

Risk and rollout

Adopted coordinators must carry current generation and selection metadata; original generation-one drafts keep their supported path. Standard publication behavior and existing ownership/path checks remain in place.

This independently reviewable change composes with checkpoint recovery. Keep it unmerged until the remaining platform and coordinated release checks pass; a completed publication must remain replayable with its original accepted input.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@github-actions github-actions Bot added the bug Something isn't working label Sep 12, 2026
@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the current head, ef9e2ab03da7adb57b35cbd0f85d4690ec1f1b76.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 12, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-12T10:01:45.719664Z ef9e2ab Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: ef9e2ab03d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant