fix(deep): fence stale publication and preserve replay - #916
Draft
mldangelo-oai wants to merge 1 commit into
Draft
mldangelo-oai wants to merge 1 commit into
mldangelo-oai wants to merge 1 commit into
Conversation
Collaborator
Author
|
@codex review Please review the current head, |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A replaced Deep coordinator can publish an obsolete aggregate over a newer result. Bind publication to the current coordinator generation and selected reducer result, and preserve replay when writing an already validated aggregate fails.
Changes
Testing
On
ef9e2ab03da7adb57b35cbd0f85d4690ec1f1b76:Risk and rollout
Adopted coordinators must carry current generation and selection metadata; original generation-one drafts keep their supported path. Standard publication behavior and existing ownership/path checks remain in place.
This independently reviewable change composes with checkpoint recovery. Keep it unmerged until the remaining platform and coordinated release checks pass; a completed publication must remain replayable with its original accepted input.
Public disclosure review