fix(deep): preserve checkpoint authority during recovery - #915
Draft
mldangelo-oai wants to merge 2 commits into
Draft
mldangelo-oai wants to merge 2 commits into
mldangelo-oai wants to merge 2 commits into
Conversation
Read each discovery checkpoint head before an older result, and freeze selected heads alongside retained source digests before publication. Preserve explicit recovery and legacy fallback semantics. Cover newer rejections, numeric archive precedence, real output-write failure, accepted partial evidence, and public workbench stop commands.
| migrate(connection, migrations) | ||
| after = [dict(row) for row in connection.execute("SELECT * FROM scans ORDER BY id")] | ||
| for original, updated in zip(before, after, strict=True): | ||
| assert updated.pop("retained_checkpoint_heads_json") is None |
Collaborator
Author
|
@codex review Please review the current head, |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stopped Deep scans can resurrect a rejected candidate by reading an older result file, or change their recovery input after a publication write fails. Read the committed checkpoint head and freeze that selection so replay preserves the accepted evidence and latest disposition.
Changes
Testing
On
bd70d41478d06331f297decd171d0d11d7fd439f:build:ci, plugin source compatibility and its tests. SDK/plugin builds passed.Risk and rollout
This draft contains both compatible readers and the frozen-head writer. Establish a reader-capable rollback artifact before enabling new writes; the schema-only commit is insufficient. Coordinate migration 47 with other open migration work and keep its identity unchanged.
The change preserves original stopped state and source digests. Legacy records without frozen-head metadata retain their existing fallback. Keep the draft unmerged until reader-first ordering and platform acceptance are complete.
Public disclosure review