fix: advance scan progress when saving drafts - #882
Merged
Merged
Conversation
ianw-oai
marked this pull request as ready for review
September 11, 2026 16:58
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kmbroai
approved these changes
Sep 11, 2026
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A Standard scan can save valid review results while its displayed phase stays at the initial step. Saving a draft did not update progress, so the display depended on separate progress calls from the scan task.
This change advances the phase when a valid draft is saved. A partial checkpoint advances the scan to at least discovery. A final draft advances it to reporting. The scan remains running until normal completion succeeds.
Changes
Testing
The same controlled scan ran against the original and patched packaged MCP server, with no explicit progress calls. The original stayed in preflight after both a partial checkpoint and a final draft. The patch advanced to discovery and reporting while the scan was still running. Both runs completed. The regression test failed on the original code and passed with the patch.
Passed:
pnpm --dir sdk/typescript run build:ci.node .github/scripts/check_plugin_source_compatibility.mjs.node --test .github/scripts/test_check_plugin_source_compatibility.mjs(9 tests).git diff --check.Native desktop verification did not reach app launch. A Python CLI-help test failed to import a sibling module with Python safe-path mode enabled. The unchanged original helper reproduced the same failure. The full Python suite was stopped after that failure. No native UI or full model-driven scan is claimed as verified.
Risk and rollout
The change applies to Standard scans. It does not change public commands, flags, schemas, or completion checks. Deep and diff scans retain their current behavior. Install the updated plugin to use the fix; an existing scan advances when it saves its next accepted checkpoint or receives an explicit progress update.
Public disclosure review