Skip to content

fix(scan): reject unsafe finding location paths in imported JSON #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevin9327 wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −0
Open

fix(scan): reject unsafe finding location paths in imported JSON #866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions sdk/typescript/src/findings-import.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,11 @@ export async function parseImportedFindings(
);
}
occurrenceIds.add(finding.occurrenceId);
if (finding.locations.some((location) => !safeFindingPath(location.path))) {
throw new CodexSecurityError(
`Findings JSON finding ${index + 1} has an invalid path.`,
);
}
}
return document.findings;
}
Expand Down
15 changes: 15 additions & 0 deletions sdk/typescript/tests-ts/findings-import.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,4 +145,19 @@ describe("findings import formats", () => {
),
).rejects.toThrow("duplicate occurrenceId");
});

test("rejects an unsafe finding location path in either import format", async () => {
const document = await sourceDocument();
document.findings[0]!.locations[0]!.path = "../../../outside/secrets.env";
await expect(
parseImportedFindings(JSON.stringify(document), "json", PLUGIN_ROOT),
).rejects.toThrow("has an invalid path");
await expect(
parseImportedFindings(
CSV_SOURCE.replace("src/extract.ts", "../../../outside/secrets.env"),
"csv",
PLUGIN_ROOT,
),
).rejects.toThrow("has an invalid path");
});
});