fix: surface deduplication review failure reasons - #766
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
ianw-oai
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deduplication failures currently discard the underlying error. Include the reason in the existing
CodexSecurityErrormessage so callers can diagnose the failure.Changes
safeErrorMessageto omit credential-bearing messages. Keep malformed JSON errors generic and omit stderr and response-detail fields.Testing
bun test --timeout 30000 tests-ts/codex-review.test.ts tests-ts/errors.test.ts: 17 passed, 3 platform-specific skips.pnpm run types: passed.pnpm run format: passed.git diff --check: passed.pnpm run test --seed 12345: attempted; stopped after broader failures, including sandbox temporary-directory ownership checks. Full-suite validation is incomplete.Risk and rollout
Only error text changes. The error class, cancellation, validation, cleanup, and finding-write behavior are unchanged. No new flags, error categories, or dependencies.
Public disclosure review