Skip to content

fix(sdk): retry Windows Get-Acl path-not-found races - #731

Merged
mldangelo-oai merged 1 commit into
mainfrom
agent/windows-credential-path-not-found
Aug 29, 2026
Merged

mldangelo-oai merged 1 commit into
mainfrom
agent/windows-credential-path-not-found

Conversation

@faizan-oai

Copy link
Copy Markdown
Contributor

Summary

Windows PowerShell can report a disappearing credential-home temporary file as GetAcl_PathNotFound_Exception,Microsoft.PowerShell.Commands.GetAclCommand. The existing snapshot retry handles a different missing-file error, so this variant can abort parallel credential imports.

Changes

  • Route only this additional exact error ID through the existing descendant-only snapshot retry.
  • Extend the existing native replay fixture with transient and persistent missing-path descendants and a missing-home control.
  • Preserve the three-attempt limit, complete-snapshot checks, and existing credential/path protections.

Testing

Native Windows checks used Node 24.19.0, Bun 1.3.14, Python 3.12.13, and the existing 30-second per-test timeout.

  • Before the production change, the three new native cases produced 1 pass and 2 expected failures: both descendant recovery cases failed; missing-home rejection passed.
  • Focused credential controls: 24 passed, 0 skipped, 0 failed (seed 2924365917).
  • Passed pnpm run types (model generation check, MCP typecheck, SDK typecheck), pnpm run format, pnpm run build:plugin, pnpm run build, and pnpm run check:plugin-source.
Full package check Passed Skipped Failed
pnpm run test --seed 12345 2018 69 4
pnpm run test (printed seed 1192751191) 2018 69 4

Both full runs failed the four existing release-automation manual-retitle cases (feat, docs, fix, and chore). Their causes remain unestablished; no additional release-case diagnostic or replay was run. These are not full-suite passes. All eight native ACL replay cases and the original parallel-import test passed in both runs.

The new cases replay native PowerShell error records deterministically; they do not reproduce the original filesystem timing.

Risk and rollout

The change is Windows-only. Missing homes and ancestors, permission failures, unexpected errors, unsafe entries, and incomplete snapshots remain fatal. Each retry still requires a complete, safe snapshot within the existing three-attempt limit. The existing missing-path continuation is unchanged; no ACL policy or public CLI setting changes.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@github-actions github-actions Bot added the bug Something isn't working label Aug 29, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-08-29T00:50:24.588082Z 1172c77 Manual request
🔒 Security Review ✅ Completed 2026-08-29T00:49:55.025702Z 1172c77 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 1172c77a19

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Contributor Author

Hosted CI for 1172c77 passed on its first attempt: node-ci completed 28/28 jobs successfully, including 18/18 Windows jobs. All three required platform checks are green.

The two local full-suite runs in the PR description still each have 2018 passed, 69 skipped, and 4 failed. The four release-retitling fixture failures remain unexplained; the hosted pass does not establish their causes or turn those local runs into passes. No workflow for this PR was rerun by this task.

@mldangelo-oai
mldangelo-oai merged commit 403df14 into main Aug 29, 2026
39 checks passed
@mldangelo-oai
mldangelo-oai deleted the agent/windows-credential-path-not-found branch August 29, 2026 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants