Skip to content

fix(ci): preserve LF Python source checkouts - #726

Merged
mldangelo-oai merged 1 commit into
mainfrom
agent/windows-python-source-eol
Aug 29, 2026
Merged

mldangelo-oai merged 1 commit into
mainfrom
agent/windows-python-source-eol

Conversation

@faizan-oai

Copy link
Copy Markdown
Contributor

Summary

Windows checkouts with core.autocrlf=true can make unchanged Python files exceed the plugin source checker's byte limit. Keep Python source checkouts in LF form so the existing size check measures the intended source bytes.

Changes

  • Add *.py text eol=lf alongside the existing extension-specific Git attributes.
  • Extend the source checker tests with a real Git checkout under repository-local core.autocrlf=true. The test verifies both the checked-out bytes and the checker result.
  • Keep the source checker's 150,000-byte limit unchanged.

Testing

  • Native Windows baseline: the unchanged checkout failed the checker for three Python files; the LF checkout passed.
  • New regression without the attribute: failed as expected at 180,000 bytes versus the 150,000-byte limit.
  • Final source-checker test file: 8 passed, 1 skipped. The skip is the existing Windows symlink test.
  • Ruff 0.16.1 lint and format checks: passed.
  • Plugin source compatibility checker: passed.

Risk and rollout

This changes Python checkout line endings, with no checker or runtime code changes. Existing unchanged CRLF files may remain until a fresh checkout or refresh; preserve local edits before doing that. No global Git settings are changed.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@github-actions github-actions Bot added the bug Something isn't working label Aug 28, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-08-28T23:47:05.178756Z 41b0064 Manual request
🔒 Security Review ✅ Completed 2026-08-28T23:47:07.189958Z 41b0064 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Contributor Author

@codex review

Copy link
Copy Markdown
Contributor Author

First hosted node-ci attempt for 41b0064: 24/28 jobs passed, with two Windows/Node 24 test failures and two downstream Windows summary-gate failures.

  • Test shard 2: the API-login cancellation test did not observe its fake-login readiness file. The test suppresses the login promise's early rejection, so the log does not distinguish a preparation error or delay from a process-startup failure.
  • Test shard 6: the pre-commit-hook fixture's initial git init reported spawnSync git ETIMEDOUT, before the hook was installed.

The plugin source-contract checks and both Windows verify jobs passed. The required Ubuntu and macOS checks passed; the Windows gate failed in this attempt. The underlying causes of the two fixture failures remain unconfirmed. No workflow rerun was performed by this task.

Copy link
Copy Markdown
Contributor Author

Update following the first-attempt report: one failed-jobs-only rerun on unchanged head 41b0064 has passed.

  • Four jobs executed again and passed: Windows/Node 24 test shards 2 and 6, plus the two Windows summary gates.
  • The other 24 successful jobs were carried over, not rerun.

All three required platform checks are green. The earlier API-login readiness and git init failures remain part of the test history; the successful rerun does not establish their underlying causes. No source or timeout changes were made for the rerun.

@mldangelo-oai
mldangelo-oai merged commit 6f92578 into main Aug 29, 2026
55 of 59 checks passed
@mldangelo-oai
mldangelo-oai deleted the agent/windows-python-source-eol branch August 29, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants