fix: include PowerShell files in diff inventory - #707
Merged
mldangelo-oai merged 1 commit intoAug 28, 2026
Merged
mldangelo-oai merged 1 commit into
mldangelo-oai merged 1 commit into
Conversation
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
mldangelo-oai
approved these changes
Aug 28, 2026
mldangelo-oai
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the clear repro and focused fix! I reproduced the missing PowerShell file on main and confirmed this change fixes both the inventory omission and the candidate-recording failure. The regression test fails before the change and passes here, and all 57 focused tests passed locally.
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #706. Diff-scan inventories currently omit changed PowerShell files because the shared text-code extension set does not include .ps1. This prevents valid locations in PowerShell files from being recorded as in-scope candidates.
Changes
Testing
Risk and rollout
This is a small compatibility fix with no public CLI or API changes. It only expands the existing diff inventory language allowlist to include PowerShell files; normal inventory behavior and other extension handling are unchanged.
Public disclosure review